Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: JTAG scan irlens handling #1447

Merged
merged 12 commits into from
Apr 11, 2023
Merged

Fix: JTAG scan irlens handling #1447

merged 12 commits into from
Apr 11, 2023

Conversation

dragonmux
Copy link
Member

Detailed description

Thanks to #1446 spurring us on, we have now addressed the way the manually specified IR lengths logic is handled as between the VLA usage, lack of length checking and other handling issues, the soundness of the IR lengths code was questionable.

This PR addresses this with a partial rewrite and finishes the refactoring work began in #1389 in jtag_scan() + cleans up the ST-Link v2 specific version of this routine. The result should be more consistent and robust with better user feedback.

This PR does slightly alter how the IR lengths are specified - dropping the need for a trailing 0 in the array, and making any 0's specified on the command line errors - but as this fixes a bug in how they could be specified and the user was not visibly aware of this behaviour/need, we think it's a safe change (changing only implementation details),

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@dragonmux dragonmux added the Bug Confirmed bug label Apr 9, 2023
@dragonmux dragonmux added this to the v1.10 milestone Apr 9, 2023
@dragonmux dragonmux requested a review from esden April 9, 2023 16:52
@dragonmux dragonmux marked this pull request as ready for review April 9, 2023 16:55
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esden esden added this pull request to the merge queue Apr 11, 2023
Merged via the queue into main with commit bcacdd4 Apr 11, 2023
@dragonmux dragonmux deleted the fix/jtag-scan-irlens-handling branch April 11, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants