-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: JTAG scan irlens handling #1447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructure about from the ST-Link v2 scan calls
…scan routine, and cleaned up
…read_irs() so both validate and read paths function the same
esden
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
Thanks to #1446 spurring us on, we have now addressed the way the manually specified IR lengths logic is handled as between the VLA usage, lack of length checking and other handling issues, the soundness of the IR lengths code was questionable.
This PR addresses this with a partial rewrite and finishes the refactoring work began in #1389 in jtag_scan() + cleans up the ST-Link v2 specific version of this routine. The result should be more consistent and robust with better user feedback.
This PR does slightly alter how the IR lengths are specified - dropping the need for a trailing 0 in the array, and making any 0's specified on the command line errors - but as this fixes a bug in how they could be specified and the user was not visibly aware of this behaviour/need, we think it's a safe change (changing only implementation details),
Your checklist for this pull request
make PROBE_HOST=native
)make PROBE_HOST=hosted
)Closing issues