Feature: mass erase target API #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perigoso
force-pushed
the
feature/mass-erase-target-api
branch
from
d0595a9 to
49b8138
Compare
perigoso
force-pushed
the
feature/mass-erase-target-api
branch
from
49b8138 to
a403c4b
Compare
dragonmux
added
Enhancement
|
Apologies this PR got a bit forgotten about.. If you could please rebase it on |
perigoso
force-pushed
the
feature/mass-erase-target-api
branch
3 times, most recently
from
235fc7e to
971b340
Compare
|
@dragonmux Managed to rebase this, sorry for the MIA... There have been quite a lot of changes since this was first submitted, and though I got things to build and it appears most changes should not affect it I could not meaningfully test things, so here be dragons. |
dragonmux
reviewed
Nov 9, 2024
target_flash_mass_erase abstracts the implementation details of the target mass erase
Move the scope of the print progress timeout creation to the common target API
target_enter_flash_mode_stub is a No-op stub for use in the target->enter_flash_mode API where the default behaviour of resetting the target is undesirable
…outine is available Targets that don't provide a dedicated mass erase routine will have it's flash erased block by block when the user requests a mass erase
Mass erase now by default manually erases target flash block by block when no specialized routine is available, the removed mass erase routine duplicates said functionality
Mass erase now by default manually erases target flash block by block when no specialized routine is available, this mass erase routine duplicates said functionality
Mass erase now by default manually erases target flash block by block when no specialized routine is available, this mass erase routine duplicates said functionality
This routine, like the other flash routines is called in between a flash prepare and flash done, with the FLASH_OPERATION_MASS_ERASE. It is meant to be used where the flash controller implements functionality to totally erase the relevant flash, and nothing else, mainly targeted at targets with multiple flash banks and funcionality to erase the banks wholly, individually
All targets that add a spi flash will have mass erase routines by default without te need to explicitly provide them, this also is more correct for scope and fixes the assumption that the first target flash registred is a spi flash
Using the buffer allocation state as a means to determine the flash operation is undefined and not guaranteed to work in the future, use proper API
When an erase is requested that would result in a complete erase of a flash and the mass erase routine is provided, use it as a speed optimization
This is a very important restriction to ensure the method is safe to use during normal load operations
perigoso
force-pushed
the
feature/mass-erase-target-api
branch
from
9afb1f9 to
5627de9
Compare
perigoso
force-pushed
the
feature/mass-erase-target-api
branch
from
7d1aadc to
3576cdf
Compare
dragonmux
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This PR is a refactor of the target mass erase API, it can be summed up in:
Target is placed in "flash mode" (enter/exit flash mode routine) before a mass erase, the flash API is used when a dedicated mass erase routine is not provided
when a specialized mass erase routine is not provided the mass erase consists of erasing all the target flash' block by block via the target flash API
This is not yet thoroughly tested, and due to the lack of targets at my disposal, it likely won't be adequately tested by just me.
Your checklist for this pull request
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues