Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add support for TM4C1294KCDT #1637

Merged

Conversation

desertsagebrush
Copy link
Contributor

@desertsagebrush desertsagebrush commented Oct 3, 2023

Detailed description

Add support for the TI TM4C1294KCDT processor. This is largely the same as the TM4C1294NCDT, although with less flash (512 KiB versus 1 MiB). With the fixes from earlier, this works on native and hosted/BMDA platforms.

Additionally, I added some extra documentation around some of the preprocessor defines to give a bit more context about what is being masked in the ID registers; I'm glad to drop this if it seems like too much.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

src/target/lmi.c Outdated Show resolved Hide resolved
@dragonmux dragonmux added New Target New debug target Documentation Project documentation labels Oct 3, 2023
@desertsagebrush desertsagebrush force-pushed the feature/tm4c1294kcdt_support branch 2 times, most recently from 4bb2f1a to 6c5646d Compare October 3, 2023 02:50
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll merge this once v1.10 is fully out the door. More documentation in-source and more information is always welcome.
Having clear information on how the device ID registers work is a good improvement.

There's one item to answer against your own review note and once handled, we'll approve this ready for the start of the v2.0 cycle as that's not far off now.

src/target/lmi.c Outdated Show resolved Hide resolved
@dragonmux dragonmux added this to the v2.0 release milestone Oct 3, 2023
 * Adds in the part ID/probe routine for the aforementioned model
 * Also adds some extra documentation/links to datasheets for where to
   find more information.
@desertsagebrush desertsagebrush force-pushed the feature/tm4c1294kcdt_support branch from 6c5646d to 09d2179 Compare October 3, 2023 03:09
@desertsagebrush
Copy link
Contributor Author

desertsagebrush commented Oct 3, 2023

Added in documentation of the family name <-> product mapping, as far as I have been able to find. I also found the proper family name for the TM4C123/LM3Fxxx devices (Blizzard), though there might be some other families floating around. I saw some references to 'Tempest' (family 0x4?) and 'Firestorm' (0x6?) when looking, although I haven't found any datasheets referencing those family names.

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! At least now, if/when those other families come to light to be added, there's some place to add them and flesh out the naming mapping.

@dragonmux dragonmux merged commit 673df3f into blackmagic-debug:main Oct 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Project documentation New Target New debug target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants