-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: assorted minor J-Link fixes #1638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of review items, but this looks good to us. What sort of urgency do you see behind these fixes landing - are they in your opinion show-stoppers for v1.10, or can they be deferred to v2.0?
It's a touch difficult to tell the severity of what's being fixed, though we're leaning toward v1.10 given the docs fixes.
some capability warning messages could be missinterpreted as not supported by BMDA or J-Link probes in general, when in reality they are just not available in this particular J-Link probe This should convey the meaning better
2000d5f
to
54daf1d
Compare
These are very low priority fixes, it can be deferred to v2.0, it should also be very low impact though, as it is in essence just a couple string changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we'll merge this when the v2.0 cycle starts then.
Detailed description
Not much to note, a couple of fix-ups done while working on other features/branches
Your checklist for this pull request
make PROBE_HOST=native
)make PROBE_HOST=hosted
)Closing issues