Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: assorted minor J-Link fixes #1638

Merged
merged 6 commits into from
Oct 29, 2023

Conversation

perigoso
Copy link
Contributor

@perigoso perigoso commented Oct 3, 2023

Detailed description

Not much to note, a couple of fix-ups done while working on other features/branches

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of review items, but this looks good to us. What sort of urgency do you see behind these fixes landing - are they in your opinion show-stoppers for v1.10, or can they be deferred to v2.0?

It's a touch difficult to tell the severity of what's being fixed, though we're leaning toward v1.10 given the docs fixes.

README.md Outdated Show resolved Hide resolved
src/platforms/hosted/jlink.c Outdated Show resolved Hide resolved
@dragonmux dragonmux added Bug Confirmed bug BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Documentation Project documentation labels Oct 3, 2023
some capability warning messages could be missinterpreted as not
supported by BMDA or J-Link probes in general, when in reality they are just
not available in this particular J-Link probe

This should convey the meaning better
@perigoso
Copy link
Contributor Author

perigoso commented Oct 3, 2023

Couple of review items, but this looks good to us. What sort of urgency do you see behind these fixes landing - are they in your opinion show-stoppers for v1.10, or can they be deferred to v2.0?

It's a touch difficult to tell the severity of what's being fixed, though we're leaning toward v1.10 given the docs fixes.

These are very low priority fixes, it can be deferred to v2.0, it should also be very low impact though, as it is in essence just a couple string changes.

@dragonmux dragonmux added this to the v2.0 release milestone Oct 3, 2023
dragonmux
dragonmux previously approved these changes Oct 3, 2023
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll merge this when the v2.0 cycle starts then.

README.md Outdated Show resolved Hide resolved
@dragonmux dragonmux merged commit 107e363 into blackmagic-debug:main Oct 29, 2023
6 checks passed
@perigoso perigoso deleted the fix/jlink-rand branch November 7, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Bug Confirmed bug Documentation Project documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants