Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: swd command message swd naming #1640

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

perigoso
Copy link
Contributor

@perigoso perigoso commented Oct 4, 2023

Detailed description

The purpose of this PR is mainly to update the SWD naming (from SW-DP to SWD ) in the SWD scan commands, since the command itself has already been renamed, it also reflects the rename of the swd scan command in the documentation, and fixes a typo and some comment farming

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good - there are a couple of tweaks it could do with but they aren't big. Let's try to land this for v1.10.

src/command.c Outdated Show resolved Hide resolved
src/command.c Show resolved Hide resolved
src/target/adiv5_swd.c Outdated Show resolved Hide resolved
@dragonmux dragonmux added this to the v1.10 milestone Oct 4, 2023
@dragonmux dragonmux added Enhancement General project improvement Documentation Project documentation labels Oct 4, 2023
@perigoso perigoso force-pushed the fix/swd-command-naming branch from 4ff99d9 to cdccb9c Compare October 5, 2023 10:59
@perigoso perigoso requested a review from dragonmux October 5, 2023 11:04
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the quick response. Merging!

@dragonmux dragonmux merged commit 0ca2fb2 into blackmagic-debug:main Oct 5, 2023
6 checks passed
@perigoso perigoso deleted the fix/swd-command-naming branch October 5, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Project documentation Enhancement General project improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants