Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: platforms/blackpill-f4: define user button port and pin #1647

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Feature: platforms/blackpill-f4: define user button port and pin #1647

merged 1 commit into from
Oct 29, 2023

Conversation

lenvm
Copy link
Contributor

@lenvm lenvm commented Oct 17, 2023

Detailed description

This pull request defines the user button with #define statements. This removes the "magic numbers" GPIOA and GPIO0 from the remaining part of the code.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

dragonmux
dragonmux previously approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll get this merged at the start of v2.0. Thank you for the contribution!

@dragonmux dragonmux added this to the v2.0 release milestone Oct 17, 2023
@dragonmux dragonmux added Enhancement General project improvement Foreign Host Board Non Native hardware to runing Black Magic firmware on labels Oct 17, 2023
@lenvm lenvm force-pushed the feature/blackpill-f4-define-user-button-port-and-pin branch from f5f714c to 5c45b1e Compare October 18, 2023 20:31
@lenvm lenvm force-pushed the feature/blackpill-f4-define-user-button-port-and-pin branch from 5c45b1e to 6774bb7 Compare October 18, 2023 21:40
@dragonmux dragonmux merged commit 3aad9ee into blackmagic-debug:main Oct 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmux dragonmux dragonmux approved these changes

Assignees
No one assigned
Labels
Enhancement General project improvement Foreign Host Board Non Native hardware to runing Black Magic firmware on
Projects
None yet
Milestone
v2.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@lenvm @dragonmux