Fix: platforms/common/stm32: fix for adc_start_conversion_direct not being defined for STM32F4 #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g defined for STM32F1, and not for STM32F4
dragonmux
approved these changes
Oct 18, 2023
dragonmux
added
Bug
lenvm
deleted the
fix/platforms-common-stm32-timing-stm32-target-get-power
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
The function
adc_start_conversion_direct()is only defined for STM32F1, and not for STM32F4.This caused a compilation issue for STM32F4 based boards.
This pull request fixes this issue, as described in #1644, by adding a check if the platform is based on an STM32F1.
Your checklist for this pull request
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues
Fixes #1644