Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cortexar: fix typo in cortexar_check_error #2011

Merged

Conversation

marysaka
Copy link
Contributor

@marysaka marysaka commented Dec 8, 2024

This should have been clearing data and mmu fault flags.

Fixes: 56f744e ("cortexar: Implemented caching for the fault information, doubling memory IO performance")

Detailed description

This should have been clearing data and mmu fault flags.

Your checklist for this pull request

Closing issues

This should have been clearing data and mmu fault flags.

Signed-off-by: Mary Guillemard <mary@mary.zone>
Fixes: 56f744e ("cortexar: Implemented caching for the fault information, doubling memory IO performance")
@dragonmux dragonmux added this to the v2.0 release milestone Dec 8, 2024
@dragonmux dragonmux added the Bug Confirmed bug label Dec 8, 2024
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. Thank you for the contribution and finding this mistake!

@marysaka marysaka closed this Dec 8, 2024
@dragonmux dragonmux merged commit 1533d14 into blackmagic-debug:main Dec 8, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants