Feature/gdb packet optimization #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonmux
reviewed
Dec 11, 2024
There was a problem hiding this comment.
This is looking awesome - really excited to see how this runs and performs. We've got just a handful of things we noticed reading through this PR and with them addressed and some testing done, we'll be happy to merge this PR. This solves some mighty nasty issues with the GDB interface logic and with its stack and heap usage!
dragonmux
added
Enhancement
perigoso
force-pushed
the
feature/gdb-packet-optimization
branch
4 times, most recently
from
306504a to
90190cf
Compare
dragonmux
reviewed
Dec 11, 2024
perigoso
force-pushed
the
feature/gdb-packet-optimization
branch
from
f16ec17 to
f4b1210
Compare
dragonmux
previously approved these changes
Dec 12, 2024
perigoso
force-pushed
the
feature/gdb-packet-optimization
branch
2 times, most recently
from
34173e9 to
3bb39b4
Compare
The tm4c platform should need the same flush workaround logic as stm32 but it was not implemented
This cleans up and reduces code duplication of gdb_putpacket2 and gdb_putpacket This also integrates data hexifing to simplify the usage on common use cases
After the streamlining of gdb_putpacket the packet is not and does not need to be modified
In a effort to reduce memory fragmentation this removes heap allocations by reusing the existing packet buffer where possible There is a large stack allocation in a particular code path, this is hopefully better for memory fragmentation though there is a chance of stack overflows, in the event it is a problem it is possible to remove allocations completely This also introduces a struct to group packet buffer data and further streamlines packet transmission
Simplify packet transmission and reception with dedicated checksum calculation function
This also adds a gdb_put_packet_ok and gdb_put_packet_error for common standard packet responses
…ailable When reading registers, the stub may also return a string of literal ‘x’’s in place of the register data digits, to indicate that the corresponding register’s value is unavailable. This indicates that the stub has no means to access the register contents, even though the corresponding register is known to exist. If a register truly does not exist on the target, then it is better to not include it in the target description in the first place.
This removes the need for strlen
This assumed the buffer was large enough to account for the NUL byte, this was an unsafe assumption, we shall limit writes to the size explicitly given to us Note, none of the current usages of this function required it to handle NUL termination
vasprintf declaration The last usage of vasprintf as been removed thus this is no longer required
perigoso
force-pushed
the
feature/gdb-packet-optimization
branch
from
3bb39b4 to
8bcdc48
Compare
dragonmux
approved these changes
Dec 14, 2024
|
Just tested these changes and they appear to be working wonderfully. Merging - thank you for this wonderful contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This tries to improve GDB packet transmission by removing dynamic allocations thus reduncing memory fragmentation potential.
Proper testing is still required.
Your checklist for this pull request
Closing issues