Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to compile blackpill-f4* with SHIELD option, using meson #2056

Merged

Conversation

lenvm
Copy link
Contributor

@lenvm lenvm commented Jan 17, 2025

Detailed description

This PR adds back the option to compile using the SHIELD macro for blackpill-f4* boards.

This functionality was available when the code was compiled using make, but got lost in the translation to meson. This PR adds back this functionality.

Your checklist for this pull request

Closing issues

@dragonmux dragonmux added this to the v2.0 release milestone Jan 17, 2025
@dragonmux dragonmux added Bug Confirmed bug Regression Bug caused by a regression Build system Build system labels Jan 17, 2025
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, so merging. Thank you for the contribution!

@dragonmux
Copy link
Member

Addendum: Please would you update your commit message to properly apply a prefix per the contrib guidelines - something like blackpill-f4/meson: in this case

@lenvm lenvm force-pushed the feature/blackpill-f4-add-shield-option branch from fa15550 to 593b906 Compare January 17, 2025 11:02
@lenvm
Copy link
Contributor Author

lenvm commented Jan 17, 2025

Sure! Commit message is updated!

@dragonmux
Copy link
Member

Thank you kindly!

@dragonmux dragonmux merged commit 593b906 into blackmagic-debug:main Jan 17, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug Build system Build system Regression Bug caused by a regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants