feat: add github gist publisher #222
Conversation
anasmuhmd
force-pushed
the
feat/github-gist-publisher
branch
from
8a1e6db to
29889fe
Compare
anasmuhmd
force-pushed
the
feat/github-gist-publisher
branch
from
9f76780 to
d79c195
Compare
|
Looks good, just found one weird issue. When |
You're right. Files within a gist are identified by their names. If name changes, it's going to be treated a different file. I guess we can read the gist before update and mark the old file for deletion. I'll update. Thanks |
anasmuhmd
force-pushed
the
feat/github-gist-publisher
branch
from
6b82be6 to
976a51f
Compare
| if !ok { | ||
| return | ||
| } | ||
| documentName := metaMap.(plugin.MapData)["name"] |
There was a problem hiding this comment.
This is the wrong name to use - the name in the meta block is the template's name, not the document name. We should use the name of the document block (I think it is available in the document map?) -- "example" in the snippet above. Document name should always be present.
| Secret: true, | ||
| }, | ||
| }, | ||
| Args: dataspec.ObjectSpec{ |
There was a problem hiding this comment.
Perhaps you can add some constraints/default values? This helps with our documentation generation (not yet done for publishers, but would be in future) and allows you to skip repetetive calls like checks for Nulls in your code
There was a problem hiding this comment.
@Andrew-Morozko As mentioned in the issue here #134, these arguments are optional. so non null constraint doesn't make sense?. We can add a default for make_public. wdyt?
| }, | ||
| } | ||
| // overrides params if defined | ||
| descriptionAttr := params.Args.GetAttr("description") |
There was a problem hiding this comment.
For example, making description constraint.NonNull and cty.StringVal("") by default can simplify the code below
Co-authored-by: Andrew Morozko <andrewmorozko@gmail.com>
anasmuhmd
force-pushed
the
feat/github-gist-publisher
branch
from
3c490f6 to
d600083
Compare
closes #134