-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for AndroidX #433
Draft
slycoder
wants to merge
2
commits into
master
Choose a base branch
from
release/v2.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Support for AndroidX #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Jest mocks (#261) * Bump acorn from 6.2.1 to 6.4.1 (#275) Bumps [acorn](https://github.com/acornjs/acorn) from 6.2.1 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.2.1...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump acorn from 5.7.3 to 5.7.4 in /Example (#274) Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump handlebars from 4.1.2 to 4.7.3 in /Example (#277) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.7.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.7.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump handlebars from 4.1.2 to 4.7.3 (#276) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.7.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.7.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Typings For Twilio video (#279) * add typings * update typings * fix participant event Co-authored-by: Francesco Lodovici <francesco.lodovici@grupposandonato.it> * dataTrack support added. (#268) * dataTrack support added. onDataTrackMessageReceived, sendString, onParticipantAddedDataTrack, onParticipantRemovedDataTrack iOS and android tested. * bump version yarn cache * onDestroy cleanup dataTrackMessageThread. Remove debug messages, add toDO and log on didReceiveData Co-authored-by: Trent Ewald <trent@caribu.com> Co-authored-by: Jonathan Chang <slycoder@gmail.com> * Fix recently introduced lint errors (#283) * Upgrade to TwilioVideo v3 on iOS (#289) * ⬆️ Upgrade to TwilioVideo v3 on iOS * 🐛 Typo fix * ⬆️ Update event names * 🐛 Fix initial mirror for front cam * 🐛 Patch black screen on Android view Thanks to @aaalaniz for patch * 🐛 Fix toggle between speaker mode in iOS * check myNoisyAudioStreamReceiver before unregistering (#295) Co-authored-by: Jeffrey Drakos <captainjeff@Jeffreys-MacBook-Pro.local> * Fix error message on android connect failure (#302) * Document minimum iOS Deployment Target (#305) * 📝 Document minimum iOS Deployment Target * 📝 Add note about setting iOS version in Project Podfile * Fix camera mirror on Android (#309) * Update proguard rules (#310) * Update README.md * Update proguard-rules.pro * Loads of fixes for the iOS example (#315) * Update local view mirroring (#314) * Actually unpublish video instead of pausing (#307) * 🐛 Unpublish video stream properly on iOS * 🐛 Unpublish Android video track instead of just pausing * 🐛 Minor fixup in Android * 🐛 Resolve properly in setLocalVideoEnabled in iOS * 🐛 Re-enable video on each conference in iOS Co-authored-by: Jonathan Chang <slycoder@gmail.com> * roomName changes to README * Fix trackIdentifier type (#325) * fix: change track identifier * fix: videoTrackId to videoTrackSid * Fix for video frozen (#321) Co-authored-by: bala_fine <bala@mfine.co> Co-authored-by: Jonathan Chang <slycoder@gmail.com> * Impact on battery life + bandwidth (#329) * Fix codec issue for ios to improve battery life * Fix codec issue for ios to improve battery life * Pass encoding parameters to control videocodec, bitrate * Not required * Gradle files clean up * Gradle files clean up * Add error message on android disconnected event (#332) * prevent re-joining participants when local video is disabled/enabled (#331) Co-authored-by: Jonathan Chang <slycoder@gmail.com> * TS: Fix connect params (#337) * Fix connect params * Add Android connect params Co-authored-by: Vladyslav Kochetkov <me@vladk.dev> * TS: Include toggleSoundSetup (#338) * Fix connect params * Add Android connect params * Add toggle sound setup type Co-authored-by: Vladyslav Kochetkov <me@vladk.dev> * Fix android example (#335) * Update android example to actually work * Fixes for Android 9+ * Run android specific methods only on android * Fix typo * Add JSMainModuleName Co-authored-by: slycoder <slycoder@gmail.com> * "On Android, the front camera appears mirrored" Issues Fixed. (#336) * test * test * test * test * test * [UPDATE]: fix mirroring function * [FIX] front camera flip (mirroring) * [FIX] remove line Co-authored-by: Jonathan Chang <slycoder@gmail.com> * TS: include setBluetoothHeadsetConnected (#339) * Set localVideoTrack to false just incase and resolve false (#340) Co-authored-by: Vladyslav Kochetkov <me@vladk.dev> * Include local participant on android (#346) This way it'll be consistent with the ios implementation Co-authored-by: Timur Amirov <timur.amirov@actio.com> * Add publish and unpublish methods for audio and video (#125) Co-authored-by: Jonathan Chang <slycoder@gmail.com> * Rotate video preview based on the VideoFrame.RotationAngle (#343) * Handle frame rotation in Android * Update TwilioRemotePreview.java * Update TwilioVideoPreviewManager.java * Update TwilioVideoPreview.java * Update TwilioVideoParticipantView.android.js * Update TwilioVideoPreview.java * Update RNVideoViewGroup.java * Update TwilioVideoPreview.java * Update TwilioRemotePreview.java * Update TwilioVideoPreviewManager.java * Remove trailing comma Co-authored-by: Jonathan Chang <slycoder@gmail.com> * iOS - Support for Disable Video Track at creation time (#347) * Fix codec issue for ios to improve battery life * Pass encoding parameters to control videocodec, bitrate * uncommit gradle * uncommit gradle * Disable Local video track at creation time * Disable auto start local video from CWM lifecycle * support enable video config for connectOptions * Fix promise valuee * remove lock file. * Fix for params * Fix for params * Address PR comment * Address PR comment * Clean code format Co-authored-by: Jonathan Chang <slycoder@gmail.com> * Publish/unpublish track methods for Android (#351) * ⬆️ Upgrade Gradle on Android As recommended by Android Studio * 🔥 Remove unnecessary binds on iOS TwilioVideo * 🆕 Implement publish/unpublish methods on Android * 🐛 Fix linter issue * iOS cleanup data track on disconnect (#352) * Bump lodash from 4.17.15 to 4.17.19 in /Example (#353) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jonathan Chang <slycoder@gmail.com> * Update twilio:video-android version to 5.10 (#363) * fix google webrtc version changed (#373) * Turn on android X for the example (#374) * Update twilio-video-ios to 3.7 for iOS 14 (#377) * Update twilio-video-ios to 3.7.0 for iOS 14 * Adjust twilio-video dependcy to include patch versions * README _onParticipantRemovedVideoTrack bugfix (#379) * README _onParticipantRemovedVideoTrack bugfix This fixes a bug in the README example where _onParticipantRemovedVideoTrack directly manipulates state and then replaces the videoTracks Map with an object. * Fix direct state manipulation in Example * [README] Converted Class Component to Function Component (#391) * Converted Class Component to Functional * Added useRef Hook * Fix - Function name change * Converted Class Component to Function Component (#395) * Converted Class Component to Functional * Added useRef Hook * Fix - Function name change * Class Component to Function Component Changed index.js file from a Class Component to Function Component, moved styles into a seperate file * Update androidx dependency Co-authored-by: Keith <keith.hackbarth@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Francesco Lodovici <francesco.lodovici@gmail.com> Co-authored-by: Francesco Lodovici <francesco.lodovici@grupposandonato.it> Co-authored-by: Trent <business@ubermc.net> Co-authored-by: Trent Ewald <trent@caribu.com> Co-authored-by: Jonathan Chang <slycoder@gmail.com> Co-authored-by: Steel Brain <i@steelbrain.me> Co-authored-by: CaptainJeff <CaptainJeff@users.noreply.github.com> Co-authored-by: Jeffrey Drakos <captainjeff@Jeffreys-MacBook-Pro.local> Co-authored-by: Daniel Reinoso <danielreinoso1807@gmail.com> Co-authored-by: Kosaku Kurino <kousaku.maron@gmail.com> Co-authored-by: Balasubramanian.M <balasnest@gmail.com> Co-authored-by: bala_fine <bala@mfine.co> Co-authored-by: chinloong <chinloong91@gmail.com> Co-authored-by: Diego Ivan Perez Michel <diego.ivan.perez.michel@gmail.com> Co-authored-by: Vladyslav Kochetkov <vladyslavkochetkov1998@gmail.com> Co-authored-by: Vladyslav Kochetkov <me@vladk.dev> Co-authored-by: Umar Nizamani <umar.nizamani@gmail.com> Co-authored-by: _junukim <junukim.dev@gmail.com> Co-authored-by: Timur Amirov <timur.deteam@gmail.com> Co-authored-by: Timur Amirov <timur.amirov@actio.com> Co-authored-by: Tyler Alves <tyler11alves@gmail.com> Co-authored-by: BeccaClipper <63307228+BeccaClipper@users.noreply.github.com> Co-authored-by: Jirawat Pattanayutanachot <jirawat.pattan@gmail.com> Co-authored-by: Stephen Lizcano <stephen@lizcano.dev> Co-authored-by: jsvegborn <josefinesvegborn@gmail.com> Co-authored-by: Marko Karapandzic <webdevmastersensei@gmail.com>
gastonmorixe
force-pushed
the
master
branch
from
September 25, 2024 15:39
7c3cd06
to
bce7e78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NonNull and Nullabel updates
Replace non-existant libraries
Replace non-existant libraries