Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera2Capturer + onCameraSwitched fix (Android) #468

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

marqroldan
Copy link
Contributor

This should be merged after #452 (I'm assuming this PR gets squashed on merge)

This adds Camera2Capturer based on https://github.com/twilio/video-quickstart-android/blob/master/quickstart/src/main/java/com/twilio/video/quickstart/util/CameraCapturerCompat.java

Tested on the following:

  • (Simulator) Android 4.4 (Google APIs)
  • (Simulator) Android 10.0 (Google APIs)
  • (SM-A715F) Android 11

Changes:

  • AndroidX was added
import androidx.annotation.NonNull;
import androidx.annotation.StringDef;
import androidx.annotation.RequiresApi;
  • ON_CAMERA_SWITCHED now happens on the camera listener's onCameraSwitched event
  • isBackCamera boolean also shows up on onConnected event
  • Addition and usage of Camera2Capturer by default based on API level

@slycoder
Copy link
Collaborator

@marqroldan Ok I've merged in #452, you should be able to merge master into this branch now.

@marqroldan
Copy link
Contributor Author

I think I haven't updated the types yet, I shall do that within 24 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants