Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update expo-build-properties installation command #702

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

amandeepmittal
Copy link
Contributor

@amandeepmittal amandeepmittal commented Apr 23, 2023

Hi 👋 Thanks for creating the config plugin for Expo!

Why

We recommend developers use the npx expo command for any Expo SDK package. It uses local/versioned Expo CLI and is tailored for each SDK version because it installs compatible package versions depending on the SDK version.

I saw your tweet about the config plugin PR and was going through the docs and thought this could be a nice enhancement. Sometimes, installing an Expo SDK package using npm or yarn might lead to incompatibility between Expo SDK's version and the package's version. We (at Expo) also follow the same pattern for installation instructions so that developers do not run into this issue. Example: https://docs.expo.dev/versions/latest/sdk/build-properties/#installation

How

By updating the command to install expo-build-properties package.

@slycoder
Copy link
Collaborator

@JonatanSalas Does this also work for you?

@JonatanSalas
Copy link
Contributor

Hi @slycoder, this would work as well. Thanks @amandeepmittal for the catch!

@slycoder slycoder merged commit 852cc87 into blackuy:master Apr 23, 2023
@amandeepmittal amandeepmittal deleted the patch-1 branch April 23, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants