Update with WPILib stuff #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing implementation will produce a cost of NaN if a tolerance of infinity is entered, but the limit approaches zero. Being able to specify that a state has no cost is useful, so this change adds support for that.
The Joseph form of the error covariance update equation is more numerically stable when the Kalman gain isn't optimal. Numerical instability and filter divergence can occur if the user goes long time periods between updates and the error covariance becomes ill-conditioned (the ratio between the largest and smallest eigenvalue gets too large).
- Add InterpolatedTreeMap for Java from team 254's 2016 MIT licensed code - Add InterpolatedMap for C++ from team 3512's code with @calcmogul (original author) permission Co-authored-by: Tyler Veness <calcmogul@gmail.com>
Remove OBE RobotDrive porting guide from MecanumDrive
Rotation2d.fromRadians() doesn't exist. The constructor should be used instead.
The math works just fine without model discretization.
value -> valid (NFC)
Co-authored-by: Starlight220 <53231611+Starlight220@users.noreply.github.com>
This previously always returned false; the get method it inherited was not used in the getAsBoolean defined in the Trigger class. The fix is to swap get() and getAsBoolean() implementations in the Trigger class.
This is a less confusing name, as enabled() can imply it enables the compressor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because some tests are failing.