Catch case where user tries to end definite manual event (#12951)

* Catch case where user tries to end definite manual event * Formatting
blakeblackshear · Aug 30, 2024 · 3eaf9f4 · 3eaf9f4
1 parent 9832831
commit 3eaf9f4
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/frigate/review/maintainer.py b/frigate/review/maintainer.py
@@ -503,8 +503,15 @@ def run(self) -> None:
                         # temporarily make it so this event can not end
                         current_segment.last_update = sys.maxsize
                     elif manual_info["state"] == ManualEventState.end:
-                        self.indefinite_events[camera].pop(manual_info["event_id"])
-                        current_segment.last_update = manual_info["end_time"]
+                        event_id = manual_info["event_id"]
+
+                        if event_id in self.indefinite_events[camera]:
+                            self.indefinite_events[camera].pop(event_id)
+                            current_segment.last_update = manual_info["end_time"]
+                        else:
+                            logger.error(
+                                f"Event with ID {event_id} has a set duration and can not be ended manually."
+                            )
             else:
                 if topic == DetectionTypeEnum.video:
                     self.check_if_new_segment(