Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally show no items #10065

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conditionally show no items #10065

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad95b08
Conditionally show no items
NickM-27 Feb 26, 2024
8e70e5d
Clean up view
NickM-27 Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions web/src/views/events/DesktopEventView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ export default function DesktopEventView({
return false;
}

return contentRef.current.scrollHeight > contentRef.current.clientHeight
}, [contentRef.current?.scrollHeight])
return contentRef.current.scrollHeight > contentRef.current.clientHeight;
}, [contentRef.current?.scrollHeight]);

// review interaction

Expand Down Expand Up @@ -276,10 +276,12 @@ export default function DesktopEventView({
</div>
)}

<div className="absolute w-full h-full flex flex-col justify-center items-center">
<LuFolderCheck className="w-16 h-16" />
There are no {severity} items to review
</div>
{reachedEnd && currentItems == null && (
<div className="w-full h-full flex flex-col justify-center items-center">
<LuFolderCheck className="w-16 h-16" />
There are no {severity} items to review
</div>
)}

<div className="w-full mr-4 md:grid md:grid-cols-3 3xl:grid-cols-4 gap-4">
{currentItems ? (
Expand Down
Loading