Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording scrubbing fixes #10439

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Recording scrubbing fixes #10439

merged 4 commits into from
Mar 14, 2024

Conversation

hawkeye217
Copy link
Collaborator

@hawkeye217 hawkeye217 commented Mar 14, 2024

There was a race condition in the initialization of a new DynamicVideoController where scrubbing inside the controller would be initially false just for a split second even though the user had not released the handlebar on the timeline from scrubbing. This PR uses the isScrubbing that gets passed back from the handlebar as a single source of truth for scrubbing.

Also, scrubbing between hours without releasing the handlebar will still cause onPlayerLoaded to be called to load a new hour. Autoplay would kick in and would start playing the new hour in the background sometimes just for a second and onTimeUpdate would be called, setting a new seeking timestamp, even though the handlebar had never been released and seeking was still true. Because seekToTimestamp automatically sets the player mode to "playback", the video player would get sometimes get confused as to what the user actually wanted to seek to when releasing the handlebar. As a result, the handlebar would sometimes jump to near the beginning of the hour, even if released at a time much later in the hour.

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit a3b930e
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/65f305edf5b73600088f0135

@hawkeye217 hawkeye217 marked this pull request as draft March 14, 2024 11:00
@hawkeye217 hawkeye217 marked this pull request as ready for review March 14, 2024 13:33
@hawkeye217 hawkeye217 marked this pull request as draft March 14, 2024 13:39
@hawkeye217 hawkeye217 marked this pull request as ready for review March 14, 2024 14:20
@NickM-27 NickM-27 merged commit 39a29d1 into dev Mar 14, 2024
13 checks passed
@NickM-27 NickM-27 deleted the scrubbing-fixes branch March 14, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants