Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race condition in the initialization of a new
DynamicVideoController
where scrubbing inside the controller would be initially false just for a split second even though the user had not released the handlebar on the timeline from scrubbing. This PR uses theisScrubbing
that gets passed back from the handlebar as a single source of truth for scrubbing.Also, scrubbing between hours without releasing the handlebar will still cause
onPlayerLoaded
to be called to load a new hour. Autoplay would kick in and would start playing the new hour in the background sometimes just for a second andonTimeUpdate
would be called, setting a new seeking timestamp, even though the handlebar had never been released and seeking was still true. BecauseseekToTimestamp
automatically sets the player mode to "playback", the video player would get sometimes get confused as to what the user actually wanted to seek to when releasing the handlebar. As a result, the handlebar would sometimes jump to near the beginning of the hour, even if released at a time much later in the hour.