Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes and small UI tweaks #11360

Merged
merged 1 commit into from
May 13, 2024
Merged

Bugfixes and small UI tweaks #11360

merged 1 commit into from
May 13, 2024

Conversation

hawkeye217
Copy link
Collaborator

@hawkeye217 hawkeye217 commented May 13, 2024 •
edited
Loading

  • Always show 0 for counts when alerts/detections are null
  • Don't scroll into view when segments update from unreviewed --> reviewed. When reviewing items without the minimap showing, playback begins and the timeline/handlebar scrolls into view. But when the segments object updates, scrollIntoView runs again unnecessarily, causing undesirable scrolling behavior. Removing segments as a dep fixes the issue.
  • Remove a few margins to better match figma

@netlify Netlify
Copy link

netlify bot commented May 13, 2024 •
edited
Loading

✅ Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 7761230
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/664207e48e792f0008149242

@NickM-27 NickM-27 merged commit fbec083 into dev May 13, 2024
13 checks passed
@NickM-27 NickM-27 deleted the bugfixes branch May 13, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickM-27 NickM-27 NickM-27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawkeye217 @NickM-27