Use camera status to get state of camera config #12787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkeye217
approved these changes
Aug 6, 2024
NickM-27
added a commit
that referenced
this pull request
Aug 8, 2024
* Use camera status to get state of camera config * Fix spelling
hawkeye217
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Use camera status to get state of camera config * Fix spelling
sandnabba
pushed a commit
to sandnabba/frigate
that referenced
this pull request
Aug 14, 2024
* Use camera status to get state of camera config * Fix spelling
NickM-27
added a commit
that referenced
this pull request
Aug 30, 2024
* Use camera status to get state of camera config * Fix spelling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config object is not reliably updated between the dispatcher and http api. We were relying on implicit behavior that they are the same in memory which is not ideal. This updates the logic to not rely on the config and instead include the current state in the camera status topic