Fix default model for rknn detector #12807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
|
Detection and ffmpeg (detect and recordings) already have health checks. The main thing that doesn't is the recordings maintainer, but that shouldn't have issues unless there is a seg fault. |
NickM-27
approved these changes
Aug 7, 2024
This seems to be the case for me. However, I guess it is a quite rare issue than and only present because of the memory issue on rockchip boards. Thank you. |
NickM-27
pushed a commit
that referenced
this pull request
Aug 8, 2024
hawkeye217
pushed a commit
that referenced
this pull request
Aug 9, 2024
sandnabba
pushed a commit
to sandnabba/frigate
that referenced
this pull request
Aug 14, 2024
NickM-27
pushed a commit
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, rknn doesn't use yolonas_s by default and will crash instead, if no model is specified. This was reported here.
I have an unrelated issue but wanted to hear some feedback before opening a separate thread for it:
There is an issue that causes FFmpeg on Rockchip boards to crash sometimes. If this issue occurs, it causes frigates whole detection process to crash silently for this camera. There is no entry in the logs and the sub-process won't restart.
Even though this issue is specific to the rockchip platform, crashes and bugs can happen on all devices. I think it would make sense to implement a health-check in Frigate that periodically checks if all sub-processes for detection and recording still run. Any thoughts on this?