Fix zmq race condition #13198
Merged
Fix zmq race condition #13198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkeye217
approved these changes
Aug 19, 2024
NickM-27
added a commit
that referenced
this pull request
Aug 23, 2024
NickM-27
added a commit
that referenced
this pull request
Aug 29, 2024
NickM-27
added a commit
that referenced
this pull request
Aug 30, 2024
iursevla
pushed a commit
to iursevla/frigate-fork
that referenced
this pull request
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZMQ is not thread safe, in some cases of very high activity a topic could be sent at the same time as a payload causing a race condition that broke the zmq reader. This can be fixed by sending the entire topic and payload as one message and is generally how ZMQ recommends doing it anyway.