Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor recordings retention to be based on review items #13355

Merged
merged 12 commits into from
Sep 2, 2024

Conversation

NickM-27
Copy link
Collaborator

This PR makes the following changes:

  • Refactor recording config to have separate retention configs for alerts and detections
    • It is now possible to define separate recording retentions for alerts and detections, removing the obscurity of the previous implementation
    • Recordings for detections can now be explicitly disabled if desired
  • Events are now always saved in the DB for detected objects if they match the alerts or detections definition. This improves searchability of events when semantic search is enabled and will improve the ability to debug review items.
  • Automatic config migration for 0.15 recording config

@NickM-27 NickM-27 linked an issue Aug 26, 2024 that may be closed by this pull request
Base automatically changed from 0.15 to dev August 30, 2024 02:19
Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit bf7560d
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/66d32a1d4273ab0008edc14f

@NickM-27 NickM-27 merged commit 0acbd3d into dev Sep 2, 2024
13 checks passed
@NickM-27 NickM-27 deleted the refactor-recordings branch September 2, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify different record config for alerts and detections
3 participants