Add live views to new webui #8970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkeye217
reviewed
Dec 15, 2023
There was a problem hiding this comment.
So I had originally created a "context" directory for hooks, but "hooks" is probably more appropriate. Maybe you could move use-persistence.tsx into hooks and then instead of index.ts, make a resize-observer.tsx or something if we want to keep separate hooks in their own files.
|
@hawkeye217 good idea, done 👍 |
hunterjm
reviewed
Dec 16, 2023
| import { Card, CardContent, CardHeader, CardTitle } from "../ui/card"; | ||
| import { Switch } from "../ui/switch"; | ||
| import { Label } from "../ui/label"; | ||
| import { usePersistence } from "@/context/use-persistence"; |
There was a problem hiding this comment.
This context is missing from this PR and doesn't exist on the 0.14 branch.
There was a problem hiding this comment.
Looks like it was moved to hooks and missed here.
There was a problem hiding this comment.
Yeah missed that one, fixed in #8981
blakeblackshear
pushed a commit
that referenced
this pull request
Dec 31, 2023
* Add support for live views * Lint fixes * Fix width * Fix lint * Cleanup hooks
blakeblackshear
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Add support for live views * Lint fixes * Fix width * Fix lint * Cleanup hooks
blakeblackshear
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Add support for live views * Lint fixes * Fix width * Fix lint * Cleanup hooks
mike2307
pushed a commit
to mike2307/frigate
that referenced
this pull request
Feb 11, 2024
* Add support for live views * Lint fixes * Fix width * Fix lint * Cleanup hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now just adding webrtc and debug because MSE and JSMPEG rely on javascript which is making things less simple. Persistence is supported and also fixed an issue on mobile with screen width