Setting motion masks to zero to improve startup calibration #9992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion, as the average frame starts out at zero
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Great find. Thanks for the PR. |
blakeblackshear
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the motion masked areas to zero, rather than 255, will speed up calibration, as the average frame starts out at zero, currently the motion masked areas take the longest time to blend into the average of any region of the frame.
Here's a comparison of frames 1, 11, 21, 31, 41, 51 of startup, with each image column exported in various stages of processing via the save_images flag in ImprovedMotionDetector
Switching the motion masked areas to black, will mean they're immediately matched to the average frame and won't risk being considered motion after everything else. The blurred areas around the motion detection should also blend into the average frame faster than their surrounding areas anyway.
The current 255 motion mask doesn't present any issue after startup, so this is only a minor improvement, but this should improve things during system start at least.