Re-enable handle-callback-err and no-ex-assign

blakeembrey · Oct 2, 2016 · df6b83e · df6b83e
1 parent 2350f55
commit df6b83e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/test/rules/handle-callback-err.out b/test/rules/handle-callback-err.out
@@ -0,0 +1,2 @@
+handle-callback-err.ts[1, 10]: Unused function: 'cb'
+handle-callback-err.ts[1, 14]: Expected error to be handled
diff --git a/test/rules/handle-callback-err.ts b/test/rules/handle-callback-err.ts
@@ -0,0 +1,3 @@
+function cb (err) {
+  console.log('hello world')
+}
diff --git a/tslint.js b/tslint.js
@@ -138,7 +138,7 @@ module.exports = {
     'no-control-regex': true,
     'no-duplicate-case': true,
     'no-empty-character-class': true,
-    // 'no-ex-assign': true,
+    'no-ex-assign': true,
     'no-extra-boolean-cast': true,
     'no-inner-declarations': [
       true,
@@ -202,10 +202,10 @@ module.exports = {
     // 'no-label-var': true,
     // 'no-shadow-restricted-names': true,
     // 'no-undef-init': true,
-    // 'handle-callback-err': [
-    //   true,
-    //   '^(err|error)$'
-    // ],
+    'handle-callback-err': [
+      true,
+      '^(err|error)$'
+    ],
     // 'no-new-require': true,
     // 'no-path-concat': true,
     'block-spacing': [
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		handle-callback-err.ts[1, 10]: Unused function: 'cb'
		handle-callback-err.ts[1, 14]: Expected error to be handled