Skip to content

Commit

Permalink
fix: ui fixes
Browse files Browse the repository at this point in the history
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
  • Loading branch information
blakepettersson committed Nov 29, 2024
1 parent 38e2032 commit 56f6800
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {DataLoader} from 'argo-ui';
import * as React from 'react';
import {Timestamp} from '../../../shared/components/timestamp';
import {ApplicationSource, RevisionMetadata, ChartDetails} from '../../../shared/models';
import {Timestamp} from '../../../shared/components';
import {ApplicationSource, RevisionMetadata, ChartDetails, OCIMetadata} from '../../../shared/models';
import {services} from '../../../shared/services';

export const RevisionMetadataRows = (props: {applicationName: string; applicationNamespace: string; source: ApplicationSource; index: number; versionId: number | null}) => {
Expand All @@ -10,22 +10,20 @@ export const RevisionMetadataRows = (props: {applicationName: string; applicatio
<DataLoader
input={props}
load={input =>
// TODO: Needs real impl
services.applications.ociMetadata(input.applicationName, input.applicationNamespace, input.source.targetRevision, input.index, input.versionId)
}>
{(m: ChartDetails) => (
// TODO: Needs real impl
{(m: OCIMetadata) => (
<div>
<div className='row'>
<div className='columns small-3'>Helm Chart:</div>
<div className='columns small-3'>OCI Image:</div>
<div className='columns small-9'>
{props.source.chart}&nbsp;
{m.home && (
{props.source.repoURL}&nbsp;
{m.imageUrl && (
<a
title={m.home}
title={m.imageUrl}
onClick={e => {
e.stopPropagation();
window.open(m.home);
window.open(m.imageUrl);
}}>
<i className='fa fa-external-link-alt' />
</a>
Expand All @@ -38,10 +36,10 @@ export const RevisionMetadataRows = (props: {applicationName: string; applicatio
<div className='columns small-9'>{m.description}</div>
</div>
)}
{m.maintainers && m.maintainers.length > 0 && (
{m.authors && m.authors.length > 0 && (
<div className='row'>
<div className='columns small-3'>Maintainers:</div>
<div className='columns small-9'>{m.maintainers.join(', ')}</div>
<div className='columns small-9'>{m.authors}</div>
</div>
)}
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ export class ApplicationDetails extends React.Component<RouteComponentProps<{app
<div className='columns small-9'>{aRevision}</div>
</div>
<div className='row white-box__details-row'>
<div className='columns small-3'>Chart Source:</div>
<div className='columns small-3'>OCI Image:</div>
<div className='columns small-9'>{aRepoUrl}</div>
</div>
</>
Expand Down

0 comments on commit 56f6800

Please sign in to comment.