fix: sets up gh-actions linting and fixes pre-commit hook #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might need further testing if the flag is not persisted across devices through git. Atleast it fixed it for me |
|
Also added linting check in next-frontend. I have seen a lot of linting errors "slipping through the cracks" in pr's |
stianjsu
changed the title
stianjsu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this, atleast for macOS
pre-commit file was not created with husky add command. The filesystem flag marking the file as an executable was not set.
Fixed by running
"chmod +x ./.husky/pre-commit" from next-frontend folder