PB-15d: Install bot to slack workspace #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a proper way to maintain a uri for accessing backend api with the next server. Right now hardcoded to be http://backend:3000 edit: done |
|
redirect flow when requests finishes or fails serverside also needs to be discussed edit: discussed |
stianjsu
force-pushed
the
install-slack-button
branch
3 times, most recently
from
6ebcc52 to
89f1af0
Compare
|
Previously after redirecting from slack, we made clientside requests to the backend for adding to workspace and logging in. Now this is done server side in getServerSideProps-functions, which happens before the user gets to visit the intermediate pages for adding to workspace and logging in. (pages/slack/callback.tsx and pages/login/callback.tsx) Simplified illustrationPreviously: (step 4-5 was inconsistent in development mode) New flow: This saves multiple roundtrips, including some I haven't drawn, making the experience when logging in smoother. Plus it should be more consistent when developing |
stianjsu
force-pushed
the
install-slack-button
branch
from
12d502b to
cbaebb7
Compare
sergiosja
reviewed
Sep 1, 2023
sergiosja
reviewed
Sep 1, 2023
sergiosja
reviewed
Sep 1, 2023
application/next-frontend/src/Landing/scenarios/Header/components/AddToSlackButton.tsx
Show resolved
Hide resolved
JacobTheisen
requested changes
Sep 1, 2023
|
Så i grunn nice ut, men noe små greier. Ikke sikkert man trenger å gjøre alt nå i første omgang, så kan eventuelt bare legge det til i backlog for senere. |
… serverside calls
stianjsu
force-pushed
the
install-slack-button
branch
from
6c2fe54 to
0e48a0d
Compare
annabjorgo
reviewed
Sep 3, 2023
annabjorgo
reviewed
Sep 3, 2023
|
lgtm! noen småting bare har også testen denne på min, og funker 🗻 |
annabjorgo
approved these changes
Sep 3, 2023
stianjsu
force-pushed
the
install-slack-button
branch
from
3e10927 to
66678c2
Compare
annabjorgo
pushed a commit
that referenced
this pull request
Sep 18, 2023
* PB-15d: adds button and redirect link for adding bot to workspace * PB-15d: reworked login and adding to slack to run serverside * PB-15d: reworked defention of api-endpoint-uri to seperate client and serverside calls * PB-15: Fixes workflow and envs for calling backend serverside * PB-15d: small styling on login and add to workspace flow * chore: Remove and adds comments * fix: sets frontenduri to new frontend * fix: removes misplaced quotation marks * PB-15d: adds better error feedback to user * ci: implements lint-staged and typechecking * ci: sets up prod envs for next-frontend when building * chore: changes to console.error and removes throw Fetch restaurants in new frontend (#23) * created hook for fetching restaurants * moved every check to a big ternary Bugfix lmdb installation (#25) * PB-15d: adds button and redirect link for adding bot to workspace * PB-15d: reworked login and adding to slack to run serverside * PB-15d: reworked defention of api-endpoint-uri to seperate client and serverside calls * PB-15: Fixes workflow and envs for calling backend serverside * PB-15d: small styling on login and add to workspace flow * chore: Remove and adds comments * fix: sets frontenduri to new frontend * fix: removes misplaced quotation marks * PB-15d: adds better error feedback to user * ci: implements lint-staged and typechecking * ci: sets up prod envs for next-frontend when building * Bugfix; lmdb return value * Bugfix; None value check --------- Co-authored-by: stianjsu <stianjsu@gmail.com> Mutation reqs (#26) * Demo for post reqs * PB-30B: Layout for mutation + toggle active status * PB-30B: Linter happy? * PB-30B: prøver på nytt * PB-30b: some refactoring + support for post and delete * PB-30b: more refactoring * PB-30b: refatoring * PB-30b: typo create hook for events called useEvents wip: proposed solution to post events with helper functions wip: useEvents and posting events add useEVent in CreateEventCard components create hook for events called useEvents wip: useEvents and posting events add useEVent in CreateEventCard components small typos implement events with restaurants posting and displaying events now working
annabjorgo
pushed a commit
that referenced
this pull request
Sep 18, 2023
* PB-15d: adds button and redirect link for adding bot to workspace * PB-15d: reworked login and adding to slack to run serverside * PB-15d: reworked defention of api-endpoint-uri to seperate client and serverside calls * PB-15: Fixes workflow and envs for calling backend serverside * PB-15d: small styling on login and add to workspace flow * chore: Remove and adds comments * fix: sets frontenduri to new frontend * fix: removes misplaced quotation marks * PB-15d: adds better error feedback to user * ci: implements lint-staged and typechecking * ci: sets up prod envs for next-frontend when building * chore: changes to console.error and removes throw
annabjorgo
pushed a commit
that referenced
this pull request
Sep 19, 2023
* PB-15d: adds button and redirect link for adding bot to workspace * PB-15d: reworked login and adding to slack to run serverside * PB-15d: reworked defention of api-endpoint-uri to seperate client and serverside calls * PB-15: Fixes workflow and envs for calling backend serverside * PB-15d: small styling on login and add to workspace flow * chore: Remove and adds comments * fix: sets frontenduri to new frontend * fix: removes misplaced quotation marks * PB-15d: adds better error feedback to user * ci: implements lint-staged and typechecking * ci: sets up prod envs for next-frontend when building * chore: changes to console.error and removes throw Fetch restaurants in new frontend (#23) * created hook for fetching restaurants * moved every check to a big ternary Bugfix lmdb installation (#25) * PB-15d: adds button and redirect link for adding bot to workspace * PB-15d: reworked login and adding to slack to run serverside * PB-15d: reworked defention of api-endpoint-uri to seperate client and serverside calls * PB-15: Fixes workflow and envs for calling backend serverside * PB-15d: small styling on login and add to workspace flow * chore: Remove and adds comments * fix: sets frontenduri to new frontend * fix: removes misplaced quotation marks * PB-15d: adds better error feedback to user * ci: implements lint-staged and typechecking * ci: sets up prod envs for next-frontend when building * Bugfix; lmdb return value * Bugfix; None value check --------- Co-authored-by: stianjsu <stianjsu@gmail.com> Mutation reqs (#26) * Demo for post reqs * PB-30B: Layout for mutation + toggle active status * PB-30B: Linter happy? * PB-30B: prøver på nytt * PB-30b: some refactoring + support for post and delete * PB-30b: more refactoring * PB-30b: refatoring * PB-30b: typo create hook for events called useEvents wip: proposed solution to post events with helper functions wip: useEvents and posting events add useEVent in CreateEventCard components create hook for events called useEvents wip: useEvents and posting events add useEVent in CreateEventCard components small typos implement events with restaurants posting and displaying events now working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements functionality for installing the bot to a workspace through the button on landing page.
Also reworks callback-pages to do login and install requests server side. See comment further down