Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch deployed frontend to Next js #30

Merged
merged 17 commits into from
Sep 13, 2023
Merged

Switch deployed frontend to Next js #30

merged 17 commits into from
Sep 13, 2023

Conversation

stianjsu
Copy link

@stianjsu stianjsu commented Sep 7, 2023

Includes all config and setup for deploying the next-frontend to Heroku through Terraform

Previously we built the frontend with github actions, and heroku served the resulting static assets with nginx. Now the frontend is built by Heroku, and the Nextjs server is run by the NodeJS plugin in heroku.

@stianjsu stianjsu force-pushed the deploy-new-frontend branch 4 times, most recently from ce25bdf to bc37ea0 Compare September 7, 2023 19:59
@stianjsu stianjsu changed the base branch from test-build to main September 7, 2023 20:24
infrastructure/system/main.tf Outdated Show resolved Hide resolved
.github/workflows/versioning.yml Outdated Show resolved Hide resolved
@stianjsu stianjsu changed the title fix: env to point to proper endpoint Switch deployed frontend to Next js Sep 7, 2023
Copy link
Author

@stianjsu stianjsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaned up changes, ready for review 🔥 🧯

Copy link

@annabjorgo annabjorgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@stianjsu stianjsu force-pushed the deploy-new-frontend branch from 24ccdd5 to ce4e27a Compare September 9, 2023 21:45
@stianjsu stianjsu force-pushed the deploy-new-frontend branch from ce4e27a to 0c715cb Compare September 9, 2023 21:49
Copy link
Collaborator

@sergiosja sergiosja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bare noen småting jeg er nysgjerrig på, men alt ser bra ut! GG<3

Copy link
Collaborator

@JacobTheisen JacobTheisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm🚀

@stianjsu stianjsu merged commit fb5b04e into main Sep 13, 2023
@stianjsu stianjsu deleted the deploy-new-frontend branch September 13, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants