Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-58: Bot dm's user instead of joining general #88

Merged
merged 11 commits into from
Dec 7, 2023

Conversation

stianjsu
Copy link

@stianjsu stianjsu commented Nov 16, 2023

Kitemaker Ticket

Gjør egt akk det som kitemaker beskriver, men tror jeg venter med å refakturere velkommenmeldingen.
Tror jeg har handlet de viktigste edge-casene, men med en safeguard på events slik at vi kan i allefall oppdage feil senere uten at noe breaker massivt.

image

@stianjsu stianjsu changed the title fix: delete properly from db when cloudinary is not set up PB-58: Bot dm's user instead of joining general Nov 16, 2023
@stianjsu stianjsu marked this pull request as draft November 16, 2023 22:23
@stianjsu stianjsu force-pushed the pb-58-dm-user-on-install branch from e0adaef to 2b75bd6 Compare November 19, 2023 13:42
@stianjsu stianjsu marked this pull request as ready for review November 19, 2023 13:44
@stianjsu
Copy link
Author

Usikker på om jeg også skal fikse hva bot-en sier i velkommen meldingen, men det kan kanskje designerene være med på å bestemme?
I såfall kan det være en egen pr

@stianjsu stianjsu force-pushed the pb-58-dm-user-on-install branch from c722306 to 26b7a2c Compare November 20, 2023 20:45
@annabjorgo
Copy link

Usikker på om jeg også skal fikse hva bot-en sier i velkommen meldingen, men det kan kanskje designerene være med på å bestemme? I såfall kan det være en egen pr

Enig at det kan ventes med, bra jobba!

Copy link
Collaborator

@JacobTheisen JacobTheisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bra jobba 🚀

@stianjsu stianjsu merged commit bd7b4f7 into main Dec 7, 2023
@stianjsu stianjsu deleted the pb-58-dm-user-on-install branch December 7, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants