Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-48c: Added second section #90

Merged
merged 7 commits into from
Nov 28, 2023
Merged

PB-48c: Added second section #90

merged 7 commits into from
Nov 28, 2023

Conversation

JacobTheisen
Copy link
Collaborator

@JacobTheisen JacobTheisen commented Nov 19, 2023

La til andre sekjsonen på landingsiden. Ikke helt lik som figma men var usikker på hvor pirkete jeg skulle være på ting.

image

I̶k̶k̶e̶ ̶h̶e̶l̶t̶ ̶f̶e̶r̶d̶i̶g̶ ̶e̶n̶d̶a̶,̶ ̶m̶å̶ ̶f̶i̶k̶s̶e̶s̶ ̶e̶n̶d̶e̶l̶ ̶p̶å̶ ̶h̶v̶o̶r̶d̶a̶n̶ ̶t̶i̶n̶g̶ ̶s̶c̶a̶l̶e̶r̶.̶
Fortsatt ikke kjempe, men er vel kanskje ikke prioritet før man har en mobilversjon å jobbe etter

Prøvde å gjøre logikken endel simplere så hvis dere bare gidder å se over en kjapp gang til så burde det være good.

@JacobTheisen JacobTheisen requested review from sergiosja, annabjorgo and stianjsu and removed request for sergiosja, annabjorgo and stianjsu November 19, 2023 18:44
@JacobTheisen JacobTheisen marked this pull request as draft November 20, 2023 10:01
Copy link
Collaborator

@sergiosja sergiosja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Herlig! Bare to ting som var litt uklare for meg!:)

@JacobTheisen JacobTheisen marked this pull request as ready for review November 23, 2023 10:57
@JacobTheisen JacobTheisen marked this pull request as draft November 23, 2023 11:07
@JacobTheisen JacobTheisen marked this pull request as ready for review November 23, 2023 15:04
@annabjorgo
Copy link

Ser bra ut! Eneste var det om vi skulle bruke queensRegular istedet for queensMedium? Tror det er regular de bruker i figma skissene`?

@JacobTheisen
Copy link
Collaborator Author

Ser bra ut! Eneste var det om vi skulle bruke queensRegular istedet for queensMedium? Tror det er regular de bruker i figma skissene`?

Stemmer! Trodde jeg hadde fiksa det men tydeligvis ikke, men fiksa nå iallefall!

@JacobTheisen JacobTheisen merged commit 55fdeb5 into main Nov 28, 2023
@JacobTheisen JacobTheisen deleted the PB-48c-landing-page branch November 28, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants