created all the customer endpoint requests.

[Dolaned]

This pull request needs some more commenting and maybe some tests but ive created all the customer end points

[mikeybeck]

Excellent, thanks for this! I've taken a quick look and it seems good to me; I'll test it out tomorrow.

[Dolaned]

all good im willing to help you complete the whole api, i would like to model some functions around the stripe on so i dont have to write different functions to get a customer object or something

[Dolaned]

I have added in some more validation to responses and added another card function in, what do you use this library for?

[Dolaned]

wait what did i miss

[mikeybeck]

Sorry I was unexpectedly busy the past week and am away at the moment which is why I haven't merged your PRs. I made and merged a PR myself the other day to urgently fix a bug. Is there a problem?

…

On Fri, 26 Apr 2019, 9:16 PM Dylan Aird, ***@***.***> wrote: wait what did i miss — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADSNI6RJMZQ6O24RPRKLALPSLB7HANCNFSM4HGFY4ZQ> .

[Dolaned]

oh i didnt realise what you did, ill have a look, what bug was it

[mikeybeck]

Ok cool thanks. It was my fault - in the exception responses I put a comma instead of a fullstop. As a result, we had a problem with our system that I simply could not track down due to lack of information. Fixing this enabled me to figure it out.

…

On Fri, 26 Apr 2019, 10:06 PM Dylan Aird, ***@***.***> wrote: oh i didnt realise what you did, ill have a look, what bug was it — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADSNI22ORIXXNOZZXOWTKLPSLH2TANCNFSM4HGFY4ZQ> .

[Dolaned]

sweet, are we able to merge this now

[mikeybeck]

Not just yet sorry; I tested it just now and got an error from Square saying the customer_id field is missing. I checked the outgoing data and saw that customer_id was null, and so was card_nonce. I'm not sure what caused this but expect to test it further and hopefully fix it tonight. Are you not getting any errors?

…

On Mon, 29 Apr 2019 at 11:56, Dylan Aird ***@***.***> wrote: sweet, are we able to merge this now — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADSNI2A7ST3B5MK73ANQWTPSY2SXANCNFSM4HGFY4ZQ> .

[Dolaned]

what function were you testing?

[mikeybeck]

The ChargeRequest function (with a saved customer/card). It works when not using a saved customer though. The error returned is: Exception when creating transaction: [HTTP/1.1 400 Bad Request] {"errors":[{"category":"INVALID_REQUEST_ERROR","code":"MISSING_REQUIRED_PARAMETER","detail":"Missing required parameter.","field":"customer_id"}]}

…

On Mon, 29 Apr 2019 at 12:03, Dylan Aird ***@***.***> wrote: what function were you testing? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADSNIYA6463J6YHOYWQBI3PSY3LVANCNFSM4HGFY4ZQ> .

[Dolaned]

how do you create the charge object
i think you need to use
payload = [
customerReference => '1',
customerCardId => '1'
]

[mikeybeck]

Ok I'll take a look, thanks

…

On Mon, 29 Apr 2019 at 12:27, Dylan Aird ***@***.***> wrote: how do you create the charge object i think you need to use payload = [ customerReference => '1', customerCardId => '1' ] — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADSNI5EMUOQ7QTJZCNYLR3PSY6IBANCNFSM4HGFY4ZQ> .

[mikeybeck]

Ah yeah I need to change 'customerId' to 'customerReference' to get it to work. Is there any benefit from this change? I'd rather keep it the way it is because this is a breaking change, but it appears noone else is using this repo at the moment so I suppose it's fine.

…

On Mon, 29 Apr 2019 at 12:38, Mike Beck ***@***.***> wrote: Ok I'll take a look, thanks On Mon, 29 Apr 2019 at 12:27, Dylan Aird ***@***.***> wrote: > how do you create the charge object > i think you need to use > payload = [ > customerReference => '1', > customerCardId => '1' > ] > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#3 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AADSNI5EMUOQ7QTJZCNYLR3PSY6IBANCNFSM4HGFY4ZQ> > . >

[Dolaned]

it was to follow in line with the stripe repo. just so if you want to use stripe, square and other providers its more consistent, its needed in our implementation

[mikeybeck]

Oh yep. We are using a couple of other providers also and have added a gateway class for each one to take care of the differences between them.
I've made a couple of modifications to our Square gateway class in order to be able to accept this PR. I'll merge it now but won't tag the release until these modifications are on production.