Fix Postgresql CSV import for older versions. #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postresql's COPY command syntax has changed from 8.x to 9.x. odo uses the new syntax, which produces a syntax error when running against 8.x and older. Below is a patch that probes the database version and applies the correct syntax. It also fixes a (suspected) bug in how encoding is inferred.
giladarnold
force-pushed
the
fix-psql-import-csv
branch
from
22b4c6f
to
8f1bf9a
Compare
llllllllll
requested changes
Dec 6, 2016
| ), | ||
| **kwargs | ||
| ) | ||
| postgres_version = element.bind.execute('select version()').scalar() |
There was a problem hiding this comment.
I am worried about the perf penalty we will pay to check this on every insert. What do you think about creating a WeakKeyDictionary from bind to version? This will let us save these checks across calls.
| escapechar=element.escapechar, | ||
| header=element.header, | ||
| encoding=element.encoding or element.bind.execute( | ||
| 'show client_encoding' |
There was a problem hiding this comment.
We could probably also memoize the encoding if we are caching the version.
| ) | ||
| postgres_version = element.bind.execute('select version()').scalar() | ||
| if int(postgres_version.split()[1].split('.')[0]) >= 9: | ||
| return compiler.process( |
There was a problem hiding this comment.
in order to make this easier to follow, what do you think about breaking these two calls into helper functions like _process_pg_8_or_lower or process_pg_9_and_greater?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postresql's COPY command syntax has changed from 8.x to 9.x. odo uses
the new syntax, which produces a syntax error when running against 8.x
and older. Below is a patch that probes the database version and applies
the correct syntax. It also fixes a (suspected) bug in how encoding is
inferred.