Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit public interface #20

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Limit public interface #20

merged 5 commits into from
Aug 20, 2024

Conversation

blazzy
Copy link
Owner

@blazzy blazzy commented Aug 20, 2024

The library is exporting more than necessary.

  • We don't need APIClient or most of api_common
  • Error is renamed to ClientError as it represents errors that only occur when initializing a Client.
  • The Error exported at the top of the crate is the Error that api requests may return.
  • Mark v5 and v4 modules in docs as only being available with the relevant feature flags

@blazzy blazzy merged commit 3e33311 into main Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@blazzy