Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.14 depends on Test::DiagINC #7

Closed
stigtsp opened this issue Feb 8, 2021 · 4 comments
Closed

v0.14 depends on Test::DiagINC #7

stigtsp opened this issue Feb 8, 2021 · 4 comments

Comments

@stigtsp
Copy link

stigtsp commented Feb 8, 2021

Hi there :)

While upgrading JavaScript::Minifier::XS in nixpkgs from v0.13 -> v0.14 I noticed that the tarball from CPAN has Test::DiagINC as a hard dependency for tests, although this is not in the cpanfile.

t/00-report-prereqs.t .. Can't locate Test/DiagINC.pm in @INC (you may need to install the Test::DiagINC module) (@INC contains: ...

@bleargh45
Copy link
Owner

That dependency on Test::DiagINC is present in Makefile.PL as well as in the META.* files (and which is unchanged from the previous v0.13 release).

Would you mind sharing how you are building/installing JavaScript::Minifier::XS, so I can get a better idea of how your system did not pull in the expected dependencies?

@stigtsp
Copy link
Author

stigtsp commented Feb 8, 2021

Woops! My apologies. A typo propagated into my system here, mistaking v0.11 for v0.13. Sorry for the disturbance. You're quite right. I've bundled Test::DiagINC with the upgrade from v0.11 -> v0.14 in nixpkgs.

@stigtsp stigtsp closed this as completed Feb 8, 2021
@bleargh45
Copy link
Owner

Ah, gotcha. Yes... when switching to using Dist::Zilla for doing release management, Test::DiagINC was added as a test dependency.

However, if you are using cpan, cpanm, or cpm to do the install then those dependencies should be getting installed properly for you.

Happy to continue to try to help diagnose build/install problems, if you care to provide more info about how your build/install is being done.

@stigtsp
Copy link
Author

stigtsp commented Feb 8, 2021

Thanks :) I'm packaging Perl modules for the nixpkgs repository, and was doing an update of JavaScript::Minifier::XS. It's a declarative way of defining environments, worth checking out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants