Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] perlPackages: bulk update #112386

Closed
wants to merge 183 commits into from

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Feb 8, 2021

Motivation for this change

Update Perl modules from CPAN

Not bumped:

After:

@stigtsp stigtsp marked this pull request as draft February 8, 2021 11:36
@stigtsp stigtsp changed the title [staging] perlPackages. [staging] perlPackages: bulk update Feb 8, 2021
@stigtsp stigtsp force-pushed the nix-update-cpan/2021-02-08 branch from 075b452 to f289b29 Compare February 8, 2021 11:42
@stigtsp stigtsp added the 1.severity: mass-rebuild This PR causes a large number of packages to rebuild label Feb 8, 2021
@stigtsp stigtsp requested review from zakame and aanderse February 8, 2021 11:56
Copy link
Member

@zakame zakame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @stigtsp for the updates!

@stigtsp stigtsp force-pushed the nix-update-cpan/2021-02-08 branch 3 times, most recently from 3b3a6ca to a8bfbc7 Compare February 8, 2021 22:21
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Feb 8, 2021
@stigtsp stigtsp force-pushed the nix-update-cpan/2021-02-08 branch 3 times, most recently from 56d29db to a2e27f4 Compare February 8, 2021 23:00
@stigtsp
Copy link
Member Author

stigtsp commented Feb 8, 2021

@GrahamcOfBorg build perlPackages.XSParseSublike perlPackages.Workflow perlPackages.URI perlPackages.TypeTiny perlPackages.Twiggy perlPackages.TreeSimpleVisitorFactory perlPackages.TreeSimple perlPackages.TreeDAGNode perlPackages.TieCycle perlPackages.TextTrim perlPackages.TestManifest perlPackages.TextCSV_XS perlPackages.TestOutput perlPackages.TestMockModule perlPackages.TestLeakTrace perlPackages.TestFile perlPackages.Test2Suite perlPackages.TermReadLineGnu perlPackages.TemplateTiny perlPackages.StringCRC32 perlPackages.SQLAbstract perlPackages.Specio perlPackages.SetObject perlPackages.RoleTiny perlPackages.RpcXML perlPackages.PodStrip perlPackages.PPIxRegexp perlPackages.PPIxQuoteLike perlPackages.PerlTidy perlPackages.PerlMagick perlPackages.perlldap perlPackages.PathTiny perlPackages.Paranoid perlPackages.NetSSLeay perlPackages.NetSFTPForeign perlPackages.NetHTTP perlPackages.Moose perlPackages.MojoPg perlPackages.Mojomysql perlPackages.MojoliciousPluginStatus perlPackages.MojoliciousPluginOpenAPI perlPackages.Mojolicious perlPackages.ModuleScanDeps perlPackages.MinionBackendmysql perlPackages.Minion perlPackages.MathGMPz perlPackages.MathBase85 perlPackages.MailAuthenticationResults perlPackages.MacPasteboard perlPackages.LWPProtocolHttps perlPackages.LWP perlPackages.LogLog4perl perlPackages.Logger perlPackages.LinkEmbedder perlPackages.libnet perlPackages.JSONValidator perlPackages.JSONParse perlPackages.JSONPP perlPackages.JSON perlPackages.JavaScriptMinifierXS perlPackages.IOTty perlPackages.IOSocketSSL perlPackages.IOInteractive perlPackages.IOCompress perlPackages.IOAIO perlPackages.IO perlPackages.HTTPMessage perlPackages.HTTPCookies perlPackages.Gtk2Unique perlPackages.Gtk2TrayIcon perlPackages.Gtk2GladeXML perlPackages.Graph perlPackages.GnuPGInterface perlPackages.Gnome2Wnck perlPackages.Gnome2VFS perlPackages.Gnome2Canvas perlPackages.Gnome2 perlPackages.FutureAsyncAwait perlPackages.Future perlPackages.FileLoadLines perlPackages.ExtUtilsMakeMaker perlPackages.ExtUtilsInstall perlPackages.EmailMIMEContentType perlPackages.DBIxSearchBuilder perlPackages.DBDCSV perlPackages.DevelPatchPerl perlPackages.DateTimeTimeZone perlPackages.DateTimeLocale perlPackages.DateTimeFormatW3CDTF perlPackages.DateTimeFormatStrptime perlPackages.DateTimeCalendarJulian perlPackages.CSSMinifierXS perlPackages.CryptPasswdMD5 perlPackages.CryptJWT perlPackages.CryptCBC perlPackages.CPANPLUS perlPackages.CPANPerlReleases perlPackages.Connector perlPackages.ConfigTiny perlPackages.ConfigMVP perlPackages.CompressRawZlib perlPackages.CompressRawBzip2 perlPackages.ClassObservable perlPackages.Catmandu perlPackages.CatalystViewCSV perlPackages.CarpAssertMore perlPackages.Cairo perlPackages.CacheFastMmap perlPackages.BusinessISBNData perlPackages.BusinessISBN perlPackages.ArrayCompare perlPackages.Appperlbrew perlPackages.Appcpm perlPackages.AppCLI perlPackages.AlienBuild perlPackages.TestDiagINC

@Mic92
Copy link
Member

Mic92 commented Feb 10, 2021

can you do the macOS testing yourself or do we need to find someone?

@stigtsp
Copy link
Member Author

stigtsp commented Feb 10, 2021

can you do the macOS testing yourself or do we need to find someone?

I can test builds on Big Sur, but any help testing these would be great ofc. :)

@stigtsp stigtsp force-pushed the nix-update-cpan/2021-02-08 branch from a2e27f4 to c820327 Compare February 10, 2021 11:26
@kvtb
Copy link
Contributor

kvtb commented Feb 13, 2021

zero changes in buildInputs and propagatedBuildInputs ?

@ghost
Copy link

ghost commented Feb 13, 2021

ExtUtils::CBuilder since it is in core, and defined twice in perl-packages.nix TODO (0.280235 fixes compilation on darwin with XCode 12, perl 5.32.1 has 0.280234)

I included to perlPackages the packages which has CPAN's version newer than core's, and removed when the versions match.
So probably ExtUtils::CBuilder is worth reincluding.
I will try to run cpan2nix on top of this PR + #110654 to see what it will find.

@ghost
Copy link

ghost commented Feb 13, 2021

  1. NetServerSSPrefork, NetZooKeeper, Tirex are candidates to move to external files as other non-CPAN modules
  2. bug: ExtUtilsCBuilder depends on config.allowAliases
{
....
  ExtUtilsCBuilder = buildPerlPackage {
....
 
} // lib.optionalAttrs (config.allowAliases or true) {
  ExtUtilsCBuilder = null; # part of Perl 5.28
}

@ghost
Copy link

ghost commented Feb 13, 2021

HTML-TableExtract, podlators, Perl-Tidy, DBIx-Class which are upgrading here were pinned in cpan2nix as "not to upgrade"
Probably their problems have gone, they need attention

@ghost
Copy link

ghost commented Feb 13, 2021

stigtsp#3

@ghost ghost mentioned this pull request Feb 15, 2021
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 16, 2021
@stigtsp stigtsp force-pushed the nix-update-cpan/2021-02-08 branch from 5dc39bb to 4341902 Compare February 17, 2021 11:38
@stigtsp stigtsp force-pushed the nix-update-cpan/2021-02-08 branch from 4341902 to ae26601 Compare March 18, 2021 11:41
@stigtsp stigtsp added this to the 21.05 milestone Mar 30, 2021
@Mic92
Copy link
Member

Mic92 commented Jun 28, 2021

Is this still relevant? It looks a bit old for a massive update.

@stigtsp
Copy link
Member Author

stigtsp commented Jun 28, 2021

Is this still relevant? It looks a bit old for a massive update.

It's relevant, but outdated. Working on an updated update.

@jonringer
Copy link
Contributor

I'm removing this as a blocker for 21.11. Doesn't feel like there's enough forward momentum on it.

@stigtsp
Copy link
Member Author

stigtsp commented Nov 29, 2021

I'm removing this as a blocker for 21.11. Doesn't feel like there's enough forward momentum on it.

I agree (and regret not following trough on this update).

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022
@stigtsp stigtsp closed this Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: mass-rebuild This PR causes a large number of packages to rebuild 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants