Fix NixOS cross compilation: Revert "[nix-update-cpan] perlPackages.HTTPDaemon: 6.01 -> 6.12" #110908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a0d34c7.
r-burns
reviewed
Jan 27, 2021
r-burns
approved these changes
Jan 27, 2021
stigtsp
reviewed
Jan 27, 2021
There was a problem hiding this comment.
Hi, This doesn't solve the problem I believe, since it's perlPackages.ModuleBuild that fails to cross build and it's pulled in via perlPackages.HTMLTagCloud as well. I'd need to look a bit more closely at this issue.
In the meanwhile, as @lopsided98 suggested in #66741, maybe it's worth considering settting perlSupport = false for git?
|
So I'm specifically looking at NixOS builds: I was able to cross-compile NixOS via mobile-nixos after reverting this commit. |
stigtsp
approved these changes
Jan 31, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent perl modules bump triggered #66741 more globally and broke NixOS cross-compilation. Reverting the HTTPDaemon bump seems to fix NixOS compilation, but doesn't address the underlying cause.
Since I'm no expert in Perl and the original issue hasn't been fixed in over a year and a half I'm proposing a revert until the issue can be resolved.