New implementation #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2016
Closed
…tive. Safe commit, won't probably even compile (it's late !!!)
|
Just wanted to drop a quick note: The style sheets are filled with duplicate styles, including some duplicates in the same block! I ran them through CSS Purge and didn't have any issues with display, so it might be worth it to run the stylesheet through it for the next update. |
|
@gelliott181 I've converted the .css file into .scss and removed duplicate styles. |
|
@jkuri Can you publish the flex branch into npm as a prerelease with a tag like |
|
@ghetolay hey, thanks for this. yes, I will do that. |
Error: Cannot find module './scripts/inline-resources'did you forgot to publish? |
|
@jkuri Yep |
Still need design work.
Well I guess it's improvement. Would be good is someone could look after it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #72.
I edited this post to remove all the explanation stuff. You can now find it on the readme directly.
The readme is too big, we will later keep the usage part and use docs/wiki for the rest.
So I see this PR as the base discussion about design matter around the new implementation. Then I'll open different issues per design choice to avoid mixing different subject and having a discussion too long.
That's it ! The first alpha release is ready !!