Remove support for model wrappers #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinvtran
force-pushed
the
drop/model-wrappers
branch
from
f727c14 to
2f493a6
Compare
dustinvtran
force-pushed
the
drop/model-wrappers
branch
4 times, most recently
from
8e49c38 to
cd429c1
Compare
dustinvtran
force-pushed
the
drop/model-wrappers
branch
from
cd429c1 to
e9aaf64
Compare
dustinvtran
force-pushed
the
drop/model-wrappers
branch
from
e9aaf64 to
2a559df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all support for model wrappers: model wrapper classes in
edward.models, theedward.statsmodule,ed.placeholder,ed.MFVI, related examples, related tests, related docs, related docstrings, and significant streamlining of the inference and criticism code bases.The result is a cleaner and leaner Edward.