Skip to content

Commit

Permalink
pkp/pkp-lib#9626 Adjust vertical alignment of icons next to texts
Browse files Browse the repository at this point in the history
  • Loading branch information
blesildaramirez committed Oct 30, 2024
1 parent 874a8f6 commit fe67219
Show file tree
Hide file tree
Showing 21 changed files with 144 additions and 34 deletions.
1 change: 1 addition & 0 deletions src/components/Container/StatsPage.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ const EditorialStatsPageWithDataAndTemplate = {
v-if="row.description"
:label="'Description for ' + row.name"
:tooltip="row.description"
icon-size="small"
></Tooltip>
</TableCell>
<TableCell>{{ row.dateRange }}</TableCell>
Expand Down
11 changes: 9 additions & 2 deletions src/components/Form/fields/FieldArchivingPn.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class="pkpFormField pkpFormField--options pkpFormField--archivingPn"
:class="classes"
>
<legend class="pkpFormField--options__legend">
<legend class="pkpFormField--options__legend flex items-center">
<template v-if="localeLabel">
<span class="aria-hidden">{{ localeLabel }}</span>
<span class="-screenReader">{{ multilingualLabel }}</span>
Expand All @@ -15,7 +15,13 @@
*
<span class="-screenReader">{{ t('common.required') }}</span>
</span>
<Tooltip v-if="tooltip" aria-hidden="true" :tooltip="tooltip" label="" />
<Tooltip
v-if="tooltip"
aria-hidden="true"
:tooltip="tooltip"
label=""
:flex="true"
/>
<span
v-if="tooltip"
:id="describedByTooltipId"
Expand All @@ -28,6 +34,7 @@
:topic="helpTopic"
:section="helpSection"
:label="t('help.help')"
:flex="true"
/>
</legend>
<div
Expand Down
15 changes: 13 additions & 2 deletions src/components/Form/fields/FieldBaseAutosuggest.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@
'pkpAutosuggest--rtl': isRTL,
}"
>
<div v-if="!isLabelInline" ref="heading" class="pkpFormField__heading">
<div
v-if="!isLabelInline"
ref="heading"
class="pkpFormField__heading flex items-center"
>
<FormFieldLabel
:control-id="controlId"
:label="label"
Expand All @@ -15,7 +19,13 @@
:required-label="t('common.required')"
:multilingual-label="multilingualLabel"
/>
<Tooltip v-if="tooltip" aria-hidden="true" :tooltip="tooltip" label="" />
<Tooltip
v-if="tooltip"
aria-hidden="true"
:tooltip="tooltip"
label=""
:flex="true"
/>
<span
v-if="tooltip"
:id="describedByTooltipId"
Expand All @@ -28,6 +38,7 @@
:topic="helpTopic"
:section="helpSection"
:label="t('help.help')"
:flex="true"
/>
</div>
<div
Expand Down
4 changes: 3 additions & 1 deletion src/components/Form/fields/FieldColor.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<fieldset class="pkpFormField pkpFormField--color">
<legend class="pkpFormField__heading--legend">
<legend class="pkpFormField__heading--legend flex items-center">
<template v-if="localeLabel">
<span class="aria-hidden">{{ localeLabel }}</span>
<span class="-screenReader">{{ multilingualLabel }}</span>
Expand All @@ -17,6 +17,7 @@
aria-hidden="true"
:tooltip="tooltip"
label=""
:flex="true"
/>
<span
v-if="isPrimaryLocale && tooltip"
Expand All @@ -30,6 +31,7 @@
:topic="helpTopic"
:section="helpSection"
:label="t('help.help')"
:flex="true"
/>
</legend>
<div
Expand Down
11 changes: 9 additions & 2 deletions src/components/Form/fields/FieldHtml.vue
Original file line number Diff line number Diff line change
@@ -1,16 +1,23 @@
<template>
<div class="pkpFormField pkpFormField--html">
<div class="pkpFormField__heading">
<div class="pkpFormField__heading flex items-center">
<span class="pkpFormFieldLabel">
{{ label }}
</span>
<Tooltip v-if="tooltip" aria-hidden="true" :tooltip="tooltip" label="" />
<Tooltip
v-if="tooltip"
aria-hidden="true"
:tooltip="tooltip"
label=""
:flex="true"
/>
<span v-if="tooltip" class="-screenReader" v-html="tooltip" />
<HelpButton
v-if="helpTopic"
:topic="helpTopic"
:section="helpSection"
:label="t('help.help')"
:flex="true"
/>
</div>
<div
Expand Down
11 changes: 9 additions & 2 deletions src/components/Form/fields/FieldMetadataSetting.vue
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
<template>
<fieldset class="pkpFormField pkpFormField--options pkpFormField--metadata">
<legend class="pkpFormField--options__legend">
<legend class="pkpFormField--options__legend flex items-center">
{{ label }}
<Tooltip v-if="tooltip" aria-hidden="true" :tooltip="tooltip" label="" />
<Tooltip
v-if="tooltip"
aria-hidden="true"
:tooltip="tooltip"
label=""
:flex="true"
/>
<span
v-if="tooltip"
:id="describedByTooltipId"
Expand All @@ -15,6 +21,7 @@
:topic="helpTopic"
:section="helpSection"
:label="t('help.help')"
:flex="true"
/>
</legend>
<div
Expand Down
10 changes: 6 additions & 4 deletions src/components/Form/fields/FieldOptions.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<fieldset class="pkpFormField pkpFormField--options" :class="classes">
<legend class="pkpFormField--options__legend">
<legend class="pkpFormField--options__legend flex items-center">
<template v-if="localeLabel">
<span class="aria-hidden">{{ localeLabel }}</span>
<span class="-screenReader">{{ multilingualLabel }}</span>
Expand All @@ -17,6 +17,7 @@
aria-hidden="true"
:tooltip="tooltip"
label=""
:flex="true"
/>
<span
v-if="isPrimaryLocale && tooltip"
Expand All @@ -30,6 +31,7 @@
:topic="helpTopic"
:section="helpSection"
:label="t('help.help')"
:flex="true"
/>
</legend>
<div
Expand Down Expand Up @@ -238,12 +240,12 @@ export default {
*/
if (this.isOrderable && this.selectedValue?.length) {
this.localizedOptions = this.localizedOptions.sort((a, b) => {
let aIndex = this.selectedValue.findIndex(value => a.value === value);
let bIndex = this.selectedValue.findIndex(value => b.value === value);
let aIndex = this.selectedValue.findIndex((value) => a.value === value);
let bIndex = this.selectedValue.findIndex((value) => b.value === value);
aIndex = aIndex === -1 ? Number.MAX_SAFE_INTEGER : aIndex;
bIndex = bIndex === -1 ? Number.MAX_SAFE_INTEGER : bIndex;
return aIndex < bIndex ? -1 : 1;
})
});
}
},
methods: {
Expand Down
11 changes: 9 additions & 2 deletions src/components/Form/fields/FieldOrcid.vue
Original file line number Diff line number Diff line change
@@ -1,16 +1,23 @@
<template>
<div class="pkpFormField pkpFormField--html">
<div class="pkpFormField__heading">
<div class="pkpFormField__heading flex items-center">
<span class="pkpFormFieldLabel">
{{ label }}
</span>
<Tooltip v-if="tooltip" aria-hidden="true" :tooltip="tooltip" label="" />
<Tooltip
v-if="tooltip"
aria-hidden="true"
:tooltip="tooltip"
label=""
:flex="true"
/>
<span v-if="tooltip" class="-screenReader" v-html="tooltip" />
<HelpButton
v-if="helpTopic"
:topic="helpTopic"
:section="helpSection"
:label="t('help.help')"
:flex="true"
/>
</div>
<div
Expand Down
11 changes: 9 additions & 2 deletions src/components/Form/fields/FieldPubId.vue
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
<template>
<div class="pkpFormField pkpFormField--pubid">
<div class="pkpFormField__heading">
<div class="pkpFormField__heading flex items-center">
<FormFieldLabel
:control-id="controlId"
:label="label"
:is-required="isRequired"
:required-label="t('common.required')"
/>
<Tooltip v-if="tooltip" aria-hidden="true" :tooltip="tooltip" label="" />
<Tooltip
v-if="tooltip"
aria-hidden="true"
:tooltip="tooltip"
label=""
:flex="true"
/>
<span
v-if="tooltip"
:id="describedByTooltipId"
Expand All @@ -20,6 +26,7 @@
:topic="helpTopic"
:section="helpSection"
:label="t('help.help')"
:flex="true"
/>
</div>
<div
Expand Down
4 changes: 3 additions & 1 deletion src/components/Form/fields/FieldRadioInput.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<fieldset class="pkpFormField pkpFormField--options" :class="classes">
<legend class="pkpFormField--options__legend">
<legend class="pkpFormField--options__legend flex items-center">
<template v-if="localeLabel">
<span class="aria-hidden">{{ localeLabel }}</span>
<span class="-screenReader">{{ multilingualLabel }}</span>
Expand All @@ -17,6 +17,7 @@
aria-hidden="true"
:tooltip="tooltip"
label=""
:flex="true"
/>
<span
v-if="isPrimaryLocale && tooltip"
Expand All @@ -30,6 +31,7 @@
:topic="helpTopic"
:section="helpSection"
:label="t('help.help')"
:flex="true"
/>
</legend>
<div
Expand Down
4 changes: 3 additions & 1 deletion src/components/Form/fields/FieldRichTextarea.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class="pkpFormField pkpFormField--richTextarea"
:class="{'-isFocused': isFocused, 'pkpFormField--richTextarea--rtl': isRTL}"
>
<div class="pkpFormField__heading">
<div class="pkpFormField__heading flex items-center">
<FormFieldLabel
:control-id="controlId"
:label="label"
Expand All @@ -17,6 +17,7 @@
aria-hidden="true"
:tooltip="tooltip"
label=""
:flex="true"
/>
<span
v-if="isPrimaryLocale && tooltip"
Expand All @@ -30,6 +31,7 @@
:topic="helpTopic"
:section="helpSection"
:label="t('help.help')"
:flex="true"
/>
</div>
<div
Expand Down
11 changes: 9 additions & 2 deletions src/components/Form/fields/FieldSelect.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div class="pkpFormField pkpFormField--select">
<div class="pkpFormField__heading">
<div class="pkpFormField__heading flex items-center">
<FormFieldLabel
:control-id="controlId"
:label="label"
Expand All @@ -9,7 +9,13 @@
:required-label="t('common.required')"
:multilingual-label="multilingualLabel"
/>
<Tooltip v-if="tooltip" aria-hidden="true" :tooltip="tooltip" label="" />
<Tooltip
v-if="tooltip"
aria-hidden="true"
:tooltip="tooltip"
label=""
:flex="true"
/>
<span
v-if="tooltip"
:id="describedByTooltipId"
Expand All @@ -22,6 +28,7 @@
:topic="helpTopic"
:section="helpSection"
:label="t('help.help')"
:flex="true"
/>
</div>
<div
Expand Down
11 changes: 9 additions & 2 deletions src/components/Form/fields/FieldSelectIssue.vue
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
<template>
<div class="pkpFormField pkpFormField--select pkpFormField--selectIssue">
<div class="pkpFormField__heading">
<div class="pkpFormField__heading flex items-center">
<FormFieldLabel
:control-id="controlId"
:label="label"
:is-required="isRequired"
:required-label="t('common.required')"
/>
<Tooltip v-if="tooltip" aria-hidden="true" :tooltip="tooltip" label="" />
<Tooltip
v-if="tooltip"
aria-hidden="true"
:tooltip="tooltip"
label=""
:flex="true"
/>
<span
v-if="tooltip"
:id="describedByTooltipId"
Expand All @@ -20,6 +26,7 @@
:topic="helpTopic"
:section="helpSection"
:label="t('help.help')"
:flex="true"
/>
</div>
<div
Expand Down
4 changes: 3 additions & 1 deletion src/components/Form/fields/FieldSlider.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div class="mt-5 max-w-lg">
<div class="pkpFormField__heading">
<div class="pkpFormField__heading flex items-center">
<FormFieldLabel
:id="labelId"
:label="label"
Expand All @@ -14,6 +14,7 @@
aria-hidden="true"
:tooltip="tooltip"
label=""
:flex="true"
/>
<span
v-if="isPrimaryLocale && tooltip"
Expand All @@ -27,6 +28,7 @@
:topic="helpTopic"
:section="helpSection"
:label="t('help.help')"
:flex="true"
/>
</div>
<div
Expand Down
Loading

0 comments on commit fe67219

Please sign in to comment.