Fixed spanish accents normalization #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavdangeti
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Looks good @svera , let's wait on one more review possibly.
abhinavdangeti
requested review from
Thejas-bhat,
metonymic-smokey,
CascadingRadium,
Likith101 and
moshaad7
abhinavdangeti
added a commit
that referenced
this pull request
Feb 13, 2024
``` * 5c7445c Abhinav Dangeti | Fix merge conflict * a0cb65a Abhinav Dangeti | Merge remote-tracking branch 'origin/master' into 7.6-couchbase |\ | * 5f1f45a Sergio Vera | Fixed spanish accents normalization (#1957) | * e26eace Mohd Shaad Khan | MB-60207 fix facets merge (#1946) | * c8e3daf Likith B | #1873: Added timeout option in the Search Handler (#1898) | * 6dee5e9 Aditi Ahuja | Added missing nil check (#1905) | * 907c83e Rahul Rampure | Added a document that demonstrates the performance benefits of docvalues (#1897) * | 8b9206a Abhi Dangeti | MB-60739: Upgrade go-faiss & zapx/v16 (#1985) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalization of accented letters only happens if the input is larger than 5 characters, something that, for example, neither
guíanorfríacomply.The solution would be to always execute the accented characters normalization, by moving it to a separate file just like it is done in the german analyzer.
Fixes: #1956