Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix windows CI (facebookresearch#2889)
Summary: facebookresearch#2882 added [a for loop, which has unsigned index, qualified with `#pragma omp parallel for`](https://github.com/facebookresearch/faiss/pull/2882/files#diff-5a89dcb99a1cce3f297c7f7dfc8e221306b281d4ced6dac1e0fc0fa54188195fR449-R452), but it seems that [MSVC doesn't support unsigned index with `#pragma omp parallel for`](https://app.circleci.com/pipelines/github/facebookresearch/faiss/4220/workflows/ee72de05-6ead-42d9-8ec5-44772e9fd41b/jobs/22529?invite=true#step-104-333) (I think this would not be conformed to OpenMP specification, but...) I (finally) change the loop with signed index. This changes introduce the precondition `n <= std::numeric_limits<std::make_signed_t<std::size_t>>::max()` , but usually this is `true` I think, so I just put this limitation as a comment instead of any `FAISS_ASSERT` or something like that. Pull Request resolved: facebookresearch#2889 Reviewed By: wickedfoo Differential Revision: D46325322 Pulled By: alexanderguzhva fbshipit-source-id: c68f4c8be3db188ac067e053c6c716e2896f75c0
- Loading branch information