Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MB-59633: Toy: Removed Encoded Value From Vellum and Set DocValues Chunk Mode to 1 #258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MB-59633: Toy: Removed Encoded Value From Vellum and Set DocValues Chunk Mode to 1 #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chunk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (

// LegacyChunkMode was the original chunk mode (always chunk size 1024)
// this mode is still used for chunking doc values.
var LegacyChunkMode uint32 = 1024
var LegacyChunkMode uint32 = 1

// DefaultChunkMode is the most recent improvement to chunking and should
// be used by default.
Expand Down
9 changes: 6 additions & 3 deletions section_inverted_text_index.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"encoding/binary"
"math"
"sort"
"strings"
"sync/atomic"

"github.com/RoaringBitmap/roaring"
Expand Down Expand Up @@ -536,9 +537,11 @@ func (io *invertedIndexOpaque) writeDicts(w *CountHashWriter) (dictOffsets []uin
}

if postingsOffset > uint64(0) {
err = io.builder.Insert([]byte(term), postingsOffset)
if err != nil {
return nil, err
if !strings.HasPrefix(term, "##") {
err = io.builder.Insert([]byte(term), postingsOffset)
if err != nil {
return nil, err
}
}
}

Expand Down
Loading