Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct path passed to bootstrap.exe by using parent directory of app_path #265

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

cary-rowen
Copy link
Collaborator

Link to issue number:

None

Summary of the issue:

Due to recent changes in PyInstaller, bootstrap.exe was receiving an incorrect path. Specifically, paths.app_path() was returning the _internal directory within the bookworm installation, instead of the expected main bookworm installation directory.

Description of how this pull request fixes the issue:

This pull request modifies the path passed to bootstrap.exe by using the parent directory of paths.app_path(). This ensures that the correct bookworm installation directory is used, thereby resolving the update process issues.

Testing performed:

  • Verified that the update process completes successfully with the correct directory passed to bootstrap.exe.
  • Checked the application behavior after the update to ensure there are no regressions.

Known issues with pull request:

  • None identified at this time.

@cary-rowen cary-rowen merged commit 9911c48 into blindpandas:develop Sep 3, 2024
1 check was pending
@cary-rowen cary-rowen deleted the fixUpdater branch September 3, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant