Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reactDOM to webapp dependencies as per MM pull 1489 #241

Open
nough opened this issue Mar 6, 2023 · 0 comments
Open

add reactDOM to webapp dependencies as per MM pull 1489 #241

nough opened this issue Mar 6, 2023 · 0 comments
Assignees

Comments

@nough
Copy link

nough commented Mar 6, 2023

Environment:

  • Mattermost version: 7.7

Recent Mattermost release has recommended that plugins add ReactDOM as an external dependency. Does this need to be done to this webapp?

https://docs.mattermost.com/upgrade/important-upgrade-notes.html
mattermost/mattermost-plugin-playbooks#1489

The fix would be to add 'react-dom': 'ReactDOM',to the externals section of webapp/webpack.config.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants