MM-47028/MM-47046 Use version of React DOM provided by web app #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
2: Dev Review
lieut-data
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Nice work @hmhealey and @nevyangelova -- appreciate the support :)
Phrynobatrachus
approved these changes
Sep 16, 2022
hmhealey
changed the title
This was referenced Sep 16, 2022
This was referenced Sep 18, 2022
Closed
Closed
Closed
trilopin
added a commit
that referenced
this pull request
Sep 20, 2022
hanzei
added
4: Reviews Complete
trilopin
added a commit
that referenced
this pull request
Oct 3, 2022
* master: (250 commits) [MM-46891] Fix collapsed LHS (#1485) Fix styled component errors (#1491) Fix a setState after unmount (#1493) Mm 44497 playbook refresh issues (#1486) Remove fetch type checking (#1492) Telemetry: new approach draft + PostUpdate viewed (#1470) Private channel/playbook in run overview at RDP (#1481) MM-47028 Use version of React DOM provided by web app (#1489) more nesting allowed for pull requests (#1476) add missing icons from mdi to compass (#1474) add portal-false to dotmenu in pbe manage members (#1479) clean unused code inside backstage (#1475) Improved logging (#1271) Translated using Weblate (Turkish) Translated using Weblate (Croatian) Translated using Weblate (Hungarian) Translated using Weblate (Dutch) Translated using Weblate (English (Australia)) Translated using Weblate (Polish) Translated using Weblate (Hungarian) ...
trilopin
added a commit
that referenced
this pull request
Oct 4, 2022
* master: Remove old checklists and related code. (#1499) Mm 46916 lhs not refreshed after unfollow (#1497) disable duplicated mochawesome logs (#1498) Mm 45998 clear playbook before saving (#1478) [MM-46891] Fix collapsed LHS (#1485) Fix styled component errors (#1491) Fix a setState after unmount (#1493) Mm 44497 playbook refresh issues (#1486) Remove fetch type checking (#1492) Telemetry: new approach draft + PostUpdate viewed (#1470) Private channel/playbook in run overview at RDP (#1481) MM-47028 Use version of React DOM provided by web app (#1489) more nesting allowed for pull requests (#1476) add missing icons from mdi to compass (#1474)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash in the ticket happens when the
CSSTransitioncomponent fromreact-transition-groupgets mounted as part of theToastBannercomponent. We're not sure specifically why that crashes, but it has to do with the Playbooks plugin compiling in a React 16 version of React DOM which is run against web app's React 17.As I mentioned in the channel, this fixes the case when the web app and plugin are both up to date, but it won't handle the old plugin/new server case since the old plugin will still have React DOM compiled into it.
One big thing thing that this doesn't include those is that Playbooks will still be developed against React 16, so unit tests will be run against React 16 and we won't get any dependency errors due to mismatched React versions. We got quite a few dependency errors when attempting to update it, and some of them appeared to be existing ones, so we left that out and filed MM-47039 to address that.
Ticket Link
https://mattermost.atlassian.net/browse/MM-47028
https://mattermost.atlassian.net/browse/MM-47046
Related Pull Requests
mattermost-community/focalboard#3861
mattermost-community/mattermost-plugin-todo#190
mattermost/mattermost-plugin-demo#153
mattermost/mattermost-plugin-starter-template#169
Checklist
[ ] Telemetry updated[ ] Gated by experimental feature flag[ ] Unit tests updated