-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-47046 Use version of React DOM provided by web app #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
changed the title
MM-47076 Use version of Reaact DOM provided by web app
MM-47076 Use version of React DOM provided by web app
Sep 16, 2022
hmhealey
changed the title
MM-47076 Use version of React DOM provided by web app
MM-47046 Use version of React DOM provided by web app
Sep 16, 2022
Thanks. I assume this can safely go in the next version (shipping with 7.4)? |
@streamer45 Yep, 7.4 |
streamer45
approved these changes
Sep 16, 2022
hmhealey
approved these changes
Sep 19, 2022
hmhealey
added
3: Reviews Complete
All reviewers have approved the pull request
and removed
2: Dev Review
Requires review by a core committer
labels
Sep 19, 2022
@streamer45 We can merge this if we want to upgrade to react 17. @hmhealey mentioned it likely wouldn't break anything since focalboard has been on React 17 for awhile already. |
Thanks @cpoile , then let's merge it now so we get some time to test it on community (starting tomorrow most likely). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
https://mattermost.atlassian.net/browse/MM-47046
Related Pull Requests
mattermost/mattermost-plugin-playbooks#1489
mattermost-community/mattermost-plugin-todo#190
mattermost-community/focalboard#3861