Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-47046 Use version of React DOM provided by web app #192

Merged
merged 2 commits into from
Oct 17, 2022
Merged

MM-47046 Use version of React DOM provided by web app #192

merged 2 commits into from
Oct 17, 2022

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Sep 16, 2022 •
edited by hmhealey
Loading

Summary

  • (From @hmhealey): For some more context, see here. The short version though is that we updated the web app to React 17, and there's a chance that plugins will have some issues with it because they're compiled with the React 16 version of ReactDOM.
  • Upgrading the dependencies that we use from webapp ("externals")
  • tested it locally on an up-to-date master

Ticket Link

https://mattermost.atlassian.net/browse/MM-47046

Related Pull Requests

mattermost/mattermost-plugin-playbooks#1489
mattermost-community/mattermost-plugin-todo#190
mattermost-community/focalboard#3861

@cpoile cpoile changed the title MM-47076 Use version of Reaact DOM provided by web app MM-47076 Use version of React DOM provided by web app Sep 16, 2022
@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Sep 16, 2022
@hmhealey hmhealey changed the title MM-47076 Use version of React DOM provided by web app MM-47046 Use version of React DOM provided by web app Sep 16, 2022
@streamer45
Copy link
Collaborator

Thanks. I assume this can safely go in the next version (shipping with 7.4)?

@cpoile
Copy link
Member Author

cpoile commented Sep 16, 2022

@streamer45 Yep, 7.4

@streamer45 streamer45 added this to the v0.9.0 / MM v7.4.0 milestone Sep 16, 2022
@hmhealey hmhealey added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 19, 2022
@cpoile cpoile added the Do Not Merge Should not be merged until this label is removed label Sep 19, 2022
@streamer45 streamer45 linked an issue Sep 20, 2022 that may be closed by this pull request
MM-47046 Use version of React DOM provided by web app #193
Closed
@streamer45 streamer45 removed this from the v0.9.0 / MM v7.4.0 milestone Oct 4, 2022
@cpoile
Copy link
Member Author

cpoile commented Oct 17, 2022

@streamer45 We can merge this if we want to upgrade to react 17. @hmhealey mentioned it likely wouldn't break anything since focalboard has been on React 17 for awhile already.

@cpoile cpoile mentioned this pull request Oct 17, 2022
Closed
@streamer45
Copy link
Collaborator

Thanks @cpoile , then let's merge it now so we get some time to test it on community (starting tomorrow most likely).

@streamer45 streamer45 added this to the v0.10.0 / MM v7.5.0 milestone Oct 17, 2022
@cpoile cpoile removed the Do Not Merge Should not be merged until this label is removed label Oct 17, 2022
@cpoile cpoile merged commit da5dfff into main Oct 17, 2022
@cpoile cpoile deleted the MM-47076-react-dom-external branch October 17, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamer45 streamer45 streamer45 approved these changes

@hmhealey hmhealey hmhealey approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.10.0 / MM v7.5.0
Development

Successfully merging this pull request may close these issues.

MM-47046 Use version of React DOM provided by web app
3 participants
@cpoile @streamer45 @hmhealey