Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-47046/MM-47052 Use version of React DOM provided by web app #81

Merged
merged 1 commit into from
Oct 4, 2022
Merged

MM-47046/MM-47052 Use version of React DOM provided by web app #81

merged 1 commit into from
Oct 4, 2022

Conversation

mickmister
Copy link
Contributor

For some more context, see here. The short version though is that we updated the web app to React 17, and there's a chance that plugins will have some issues with it because they're compiled with the React 16 version of ReactDOM. I'm submitting PRs to the 3 products, the demo plugin, and the plugin template to have them use the web app's version of React DOM to fix any immediate issues, but we'll want to properly migrate them to React 17 going forward.

Ticket Link

https://mattermost.atlassian.net/browse/MM-47046

Related Pull Requests

@mickmister mickmister requested a review from hmhealey September 17, 2022 15:09
@mickmister mickmister merged commit 0d97b40 into master Oct 4, 2022
@mickmister mickmister deleted the react-dom-webpack-externals branch October 4, 2022 03:40
@mickmister mickmister mentioned this pull request Oct 4, 2022
Closed
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Oct 4, 2022
@hanzei hanzei added this to the v1.4.0 milestone Oct 4, 2022
mickmister added a commit that referenced this pull request Oct 28, 2022
@mickmister
add react-dom to webpack externals (#81)
c2bc39b
This was referenced Oct 28, 2022
Closed
Merged
mickmister added a commit that referenced this pull request Nov 4, 2022
@mickmister @hanzei
Release 1.3.1 (#84)
b8c4e0d 
* add react-dom to webpack externals (#81)

* bump version 1.3.1

* Fix linter errors (#85)

* lint

* go mod tidy

* go get golang.org/x/sys

* go mod tidy

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmhealey hmhealey hmhealey approved these changes

@marianunez marianunez Awaiting requested review from marianunez

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mickmister @hmhealey @hanzei