Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more nesting allowed for pull requests #1476

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

trilopin
Copy link
Contributor

Summary

Sometimes the pr summary is complex enough to have it's own sections. Why not the current sections are bigger (##) to create more space for smaller headings (### and ####)

Ticket Link

Nope

Checklist

  • Telemetry updated
  • Gated by experimental feature flag
  • Unit tests updated

@trilopin trilopin added the 2: Dev Review Requires review by a core committer label Sep 12, 2022
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm game! I also think @calebroseland was wondering about removing the Checklist altogether a while back. 0/5

@calebroseland calebroseland merged commit 38aac38 into master Sep 16, 2022
@calebroseland calebroseland deleted the give_me_more_levels branch September 16, 2022 13:26
trilopin added a commit that referenced this pull request Sep 20, 2022
* master:
  MM-47028 Use version of React DOM provided by web app (#1489)
  more nesting allowed for pull requests (#1476)
  add missing icons from mdi to compass (#1474)
  add portal-false to dotmenu in pbe manage members (#1479)
trilopin added a commit that referenced this pull request Sep 20, 2022
* master:
  MM-47028 Use version of React DOM provided by web app (#1489)
  more nesting allowed for pull requests (#1476)
  add missing icons from mdi to compass (#1474)
  add portal-false to dotmenu in pbe manage members (#1479)
  clean unused code inside backstage (#1475)
trilopin added a commit that referenced this pull request Oct 3, 2022
* master: (250 commits)
  [MM-46891] Fix collapsed LHS (#1485)
  Fix styled component errors (#1491)
  Fix a setState after unmount (#1493)
  Mm 44497 playbook refresh issues (#1486)
  Remove fetch type checking (#1492)
  Telemetry: new approach draft + PostUpdate viewed (#1470)
  Private channel/playbook in run overview at RDP (#1481)
  MM-47028 Use version of React DOM provided by web app (#1489)
  more nesting allowed for pull requests (#1476)
  add missing icons from mdi to compass (#1474)
  add portal-false to dotmenu in pbe manage members (#1479)
  clean unused code inside backstage (#1475)
  Improved logging (#1271)
  Translated using Weblate (Turkish)
  Translated using Weblate (Croatian)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Dutch)
  Translated using Weblate (English (Australia))
  Translated using Weblate (Polish)
  Translated using Weblate (Hungarian)
  ...
trilopin added a commit that referenced this pull request Oct 4, 2022
* master:
  MM-47028 Use version of React DOM provided by web app (#1489)
  more nesting allowed for pull requests (#1476)
  add missing icons from mdi to compass (#1474)
trilopin added a commit that referenced this pull request Oct 4, 2022
* master:
  Remove old checklists and related code. (#1499)
  Mm 46916 lhs not refreshed after unfollow (#1497)
  disable duplicated mochawesome logs (#1498)
  Mm 45998 clear playbook before saving (#1478)
  [MM-46891] Fix collapsed LHS (#1485)
  Fix styled component errors (#1491)
  Fix a setState after unmount (#1493)
  Mm 44497 playbook refresh issues (#1486)
  Remove fetch type checking (#1492)
  Telemetry: new approach draft + PostUpdate viewed (#1470)
  Private channel/playbook in run overview at RDP (#1481)
  MM-47028 Use version of React DOM provided by web app (#1489)
  more nesting allowed for pull requests (#1476)
  add missing icons from mdi to compass (#1474)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants